feat(dossier): multiselect without react

spec/controllers/instructeurs/dossiers_controller_spec.rb

@@ -824,7 +824,7 @@ describe Instructeurs::DossiersController, type: :controller do
       end
 
       it {
-        expect(champ_multiple_drop_down_list.value).to eq('["val1", "val2"]')
+        expect(champ_multiple_drop_down_list.value).to eq('["val1","val2"]')
         expect(champ_linked_drop_down_list.primary_value).to eq('primary')
         expect(champ_linked_drop_down_list.secondary_value).to eq('secondary')
         expect(champ_datetime.value).to eq('2019-12-21T13:17:00+01:00')

spec/models/champ_spec.rb

@@ -117,7 +117,7 @@ describe Champ do
     # when using the old form, and the ChampsService Class
     # TODO: to remove
     context 'when the value is already deserialized' do
-      let(:value) { '["val1", "val2"]' }
+      let(:value) { '["val1","val2"]' }
 
       it { expect(champ.value).to eq(value) }
 
@@ -135,7 +135,7 @@ describe Champ do
       context 'when a choice is selected' do
         let(:value) { '["", "val1", "val2"]' }
 
-        it { expect(champ.value).to eq('["val1", "val2"]') }
+        it { expect(champ.value).to eq('["val1","val2"]') }
       end
 
       context 'when all choices are removed' do

spec/models/champs/multiple_drop_down_list_champ_spec.rb

@@ -1,12 +1,11 @@
 describe Champs::MultipleDropDownListChamp do
+  let(:type_de_champ) { build(:type_de_champ_multiple_drop_down_list, drop_down_list_value: "val1\r\nval2\r\nval3") }
+  let(:value) { nil }
+  subject { build(:champ_multiple_drop_down_list, type_de_champ:, value:) }
+
   describe 'validations' do
     describe 'inclusion' do
-      let(:type_de_champ) { build(:type_de_champ_multiple_drop_down_list, drop_down_list_value: "val1\r\nval2\r\nval3") }
-      subject { build(:champ_multiple_drop_down_list, type_de_champ:, value:) }
-
       context 'when the value is nil' do
-        let(:value) { nil }
-
         it { is_expected.to be_valid }
       end
 
@@ -35,4 +34,28 @@ describe Champs::MultipleDropDownListChamp do
       end
     end
   end
+
+  describe '#next_checkbox_id' do
+    let(:value) { ["val1", "val2", "val3"] }
+
+    context 'when the value has next value' do
+      it {
+        expect(subject.next_checkbox_id("val1")).to eq(subject.checkbox_id("val2"))
+        expect(subject.next_checkbox_id("val2")).to eq(subject.checkbox_id("val3"))
+      }
+    end
+
+    context 'when the value is last' do
+      it { expect(subject.next_checkbox_id("val3")).to eq(subject.checkbox_id("val2")) }
+    end
+
+    context 'when the value is invalid' do
+      it { expect(subject.next_checkbox_id("val4")).to eq(nil) }
+    end
+
+    context 'when the values are empty' do
+      let(:value) { [] }
+      it { expect(subject.next_checkbox_id("val1")).to eq(nil) }
+    end
+  end
 end

spec/models/concern/dossier_rebase_concern_spec.rb

@@ -454,7 +454,7 @@ describe DossierRebaseConcern do
           tdc_to_update.update(drop_down_list_value: "option\nupdated")
         end
 
-        it { expect { subject }.to change { dossier.champs_public.first.value }.from('["v1", "option"]').to('["option"]') }
+        it { expect { subject }.to change { dossier.champs_public.first.value }.from('["v1","option"]').to('["option"]') }
       end
 
       context 'when a dropdown unused option is removed' do

spec/system/users/brouillon_spec.rb

@@ -38,8 +38,8 @@ describe 'The user' do
     check('val1')
     check('val3')
     select('bravo', from: form_id_for('simple_choice_drop_down_list_long'))
-    select_combobox('multiple_choice_drop_down_list_long', 'alp', 'alpha')
-    select_combobox('multiple_choice_drop_down_list_long', 'cha', 'charly')
+    select('alpha', from: form_id_for('multiple_choice_drop_down_list_long'))
+    select('charly', from: form_id_for('multiple_choice_drop_down_list_long'))
 
     select('Australie', from: form_id_for('pays'))
     select('Martinique', from: form_id_for('regions'))
@@ -97,7 +97,10 @@ describe 'The user' do
     expect(page).to have_selected_value('pays', selected: 'Australie')
     expect(page).to have_selected_value('regions', selected: 'Martinique')
     expect(page).to have_selected_value('departements', selected: '02 – Aisne')
-    check_selected_value('multiple_choice_drop_down_list_long', with: ['alpha', 'charly'])
+    within("##{champ_for('multiple_choice_drop_down_list_long').input_group_id}") do
+      expect(page).to have_button('alpha')
+      expect(page).to have_button('charly')
+    end
     expect(page).to have_selected_value('communes', selected: 'Brétigny (60400)')
     expect(page).to have_selected_value('pays', selected: 'Australie')
     expect(page).to have_field('dossier_link', with: '123')
@@ -530,8 +533,12 @@ describe 'The user' do
   end
 
   def champ_value_for(libelle)
+    champ_for(libelle).value
+  end
+
+  def champ_for(libelle)
     champs = user_dossier.reload.champs_public
-    champs.find { |c| c.libelle == libelle }.value
+    champs.find { |c| c.libelle == libelle }
   end
 
   def fill_individual

spec/views/shared/dossiers/_edit.html.haml_spec.rb

@@ -101,7 +101,7 @@ describe 'shared/dossiers/edit.html.haml', type: :view do
       let(:champ_value) { ['banana', 'grapefruit'].to_json }
 
       it 'renders the list as a multiple-selection dropdown' do
-        expect(subject).to have_selector('[data-react-component-value="ComboMultipleDropdownList"]')
+        expect(subject).to have_selector('select')
       end
     end
   end