DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

editor: insert new champs after the last fully visible champ

Browse source 
Before, when the "Add new champ" button was clicked, the new champ
was inserted after the **first** fully visible champ.

That was most of the time unexpected. The correct behavior would be to
insert the new champ after the **last** fully visible champ.

That's what this commit does. Now the "Add new champ" behavior feels
much less confusing.
This commit is contained in:
Pierre de La Morinerie 2019-11-07 15:19:11 +01:00
parent 91002865b0
commit fc8a0d46ff
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/javascript/components/TypesDeChampEditor/typeDeChampsReducer.js
View file

@ -219,7 +219,7 @@ function getUpdateHandler(typeDeChamp, { queue, flash }) {
} }
function findItemToInsertAfter() { function findItemToInsertAfter() {
const target = getFirstTarget(); const target = getLastVisibleTypeDeChamp();
return { return {
target, target,
@ -227,8 +227,10 @@ function findItemToInsertAfter() {
}; };
} }
function getFirstTarget() { function getLastVisibleTypeDeChamp() {
const [target] = document.querySelectorAll('[data-in-view]'); const typeDeChamps = document.querySelectorAll('[data-in-view]');
const target = typeDeChamps[typeDeChamps.length - 1];
if (target) { if (target) {
const parentTarget = target.closest('[data-repetition]'); const parentTarget = target.closest('[data-repetition]');
if (parentTarget) { if (parentTarget) {