refactor(links): use FAQ URL locale everywhere

app/views/layouts/_header.haml

@@ -51,7 +51,7 @@
                   = render partial: 'shared/help/help_dropdown_instructeur'
                 - else
                   // NB: on mobile in order to have links correctly aligned, we need a left icon
-                  = link_to t('help'), FAQ_URL, class: 'fr-btn fr-icon-questionnaire-line fr-btn--icon-left', title: new_tab_suffix(t('help')), **external_link_attributes
+                  = link_to t('help'), t("links.footer.faq.url"), class: 'fr-btn fr-icon-questionnaire-line fr-btn--icon-left', title: new_tab_suffix(t('help')), **external_link_attributes
 
 
 

app/views/root/administration.html.haml

@@ -120,4 +120,4 @@
           %h1.cta-panel-title Une question, un problème ?
           %p.cta-panel-explanation Consultez notre FAQ
         %div
-          = link_to "Voir la FAQ", FAQ_URL, class: "fr-btn fr-btn--lg", **external_link_attributes
+          = link_to "Voir la FAQ", t("links.footer.faq.url"), class: "fr-btn fr-btn--lg", **external_link_attributes

app/views/root/landing.html.haml

@@ -51,7 +51,7 @@
           %h2.cta-panel-title= t(".question")
           %p.cta-panel-explanation= t(".answer_in_faq")
         %div
-          = link_to t(".online_help"), FAQ_URL, class: "fr-btn fr-btn--lg", title: new_tab_suffix(t(".online_help")), **external_link_attributes
+          = link_to t(".online_help"), t("links.footer.faq.url"), class: "fr-btn fr-btn--lg", title: new_tab_suffix(t(".online_help")), **external_link_attributes
         -#   We temporarily disable the link to the contact page on the homepage
         -#   %p.cta-panel-explanation Notre équipe est disponible pour vous renseigner et vous aider
         -# %div

app/views/shared/help/dropdown_items/_faq_item.html.haml

@@ -1,5 +1,5 @@
 %li
-  = link_to FAQ_URL, title: new_tab_suffix(t('help_dropdown.general_title')), **external_link_attributes do
+  = link_to t("links.footer.faq.url"), title: new_tab_suffix(t('help_dropdown.general_title')), **external_link_attributes do
     %span.icon.help
     .dropdown-description
       %span.help-dropdown-title

spec/system/help_spec.rb

@@ -19,7 +19,7 @@ describe 'Getting help:' do
       within('.help-dropdown') do
         expect(page).to have_content(procedure.service.email)
         expect(page).to have_content(procedure.service.telephone)
-        expect(page).to have_link(nil, href: FAQ_URL)
+        expect(page).to have_link(nil, href: I18n.t("links.footer.faq.url"))
       end
     end
   end
@@ -52,7 +52,7 @@ describe 'Getting help:' do
         within('.help-dropdown') do
           expect(page).to have_content(dossier.procedure.service.email)
           expect(page).to have_content(dossier.procedure.service.telephone)
-          expect(page).to have_link(nil, href: FAQ_URL)
+          expect(page).to have_link(nil, href: I18n.t("links.footer.faq.url"))
         end
       end
     end
@@ -69,7 +69,7 @@ describe 'Getting help:' do
 
         within('.help-dropdown') do
           expect(page).to have_link(nil, href: messagerie_dossier_path(dossier))
-          expect(page).to have_link(nil, href: FAQ_URL)
+          expect(page).to have_link(nil, href: I18n.t("links.footer.faq.url"))
         end
       end
     end
@@ -91,7 +91,7 @@ describe 'Getting help:' do
   end
 
   def have_help_button
-    have_link('Aide', href: FAQ_URL)
+    have_link('Aide', href: I18n.t("links.footer.faq.url"))
   end
 
   def have_help_menu

spec/views/layouts/_header_spec.rb

@@ -23,7 +23,7 @@ describe 'layouts/_header.html.haml', type: :view do
     it { is_expected.to_not have_css(".account-btn") }
 
     it 'displays the Help link' do
-      expect(subject).to have_link('Aide', href: FAQ_URL)
+      expect(subject).to have_link('Aide', href: I18n.t("links.footer.faq.url"))
     end
 
     context 'when on a procedure page' do
@@ -48,7 +48,7 @@ describe 'layouts/_header.html.haml', type: :view do
     it { is_expected.to have_selector(:button, user.email, class: "account-btn") }
 
     it 'displays the Help button' do
-      expect(subject).to have_link("Aide", href: FAQ_URL)
+      expect(subject).to have_link("Aide", href: I18n.t("links.footer.faq.url"))
     end
   end