Merge pull request #3090 from tchak/fix-number-champs-validation

Fix number champs validation

app/models/champs/decimal_number_champ.rb

@@ -1,5 +1,5 @@
 class Champs::DecimalNumberChamp < Champ
-  validates :value, numericality: { allow_nil: true }
+  validates :value, numericality: { allow_nil: true, allow_blank: true }
 
   def value_for_export
     value.to_f

app/models/champs/integer_number_champ.rb

@@ -1,5 +1,5 @@
 class Champs::IntegerNumberChamp < Champ
-  validates :value, numericality: { only_integer: true, allow_nil: true }
+  validates :value, numericality: { only_integer: true, allow_nil: true, allow_blank: true }
 
   def value_for_export
     value.to_i

spec/models/champs/decimal_number_champ_spec.rb

@@ -21,5 +21,17 @@ describe Champs::DecimalNumberChamp do
 
       it { is_expected.to_not be_valid }
     end
+
+    context 'when the value is blank' do
+      let(:value) { '' }
+
+      it { is_expected.to be_valid }
+    end
+
+    context 'when the value is nil' do
+      let(:value) { nil }
+
+      it { is_expected.to be_valid }
+    end
   end
 end

spec/models/champs/integer_number_champ_spec.rb

@@ -21,5 +21,17 @@ describe Champs::IntegerNumberChamp do
 
       it { is_expected.to_not be_valid }
     end
+
+    context 'when the value is blank' do
+      let(:value) { '' }
+
+      it { is_expected.to be_valid }
+    end
+
+    context 'when the value is nil' do
+      let(:value) { nil }
+
+      it { is_expected.to be_valid }
+    end
   end
 end