chore(rubocop): cleanup dependencies

Using rubocop-rails_config is a nonsense because:
  - it relies on rubocop-minitest which is useless here (we use RSpec)
  - it relies on rubocop-packaging but disables all its cops
  - it targets ruby version 2.7, but we use 3.0
This commit is contained in:
François Vantomme 2022-01-05 15:39:23 +01:00 committed by Pierre de La Morinerie
parent ad545771b7
commit f3bf0499b6
3 changed files with 12 additions and 17 deletions

View file

@ -1,15 +1,15 @@
require: require:
- rubocop-performance
- rubocop-rails
- rubocop/rspec/focused - rubocop/rspec/focused
- ./lib/cops/add_concurrent_index.rb - ./lib/cops/add_concurrent_index.rb
- ./lib/cops/application_name.rb - ./lib/cops/application_name.rb
- ./lib/cops/unscoped.rb - ./lib/cops/unscoped.rb
inherit_gem:
rubocop-rails_config:
- config/rails.yml
AllCops: AllCops:
TargetRubyVersion: 2.7 TargetRubyVersion: 3.0
DisabledByDefault: true
SuggestExtensions: false
Exclude: Exclude:
- "db/schema.rb" - "db/schema.rb"
- "db/migrate/20190730153555_recreate_structure.rb" - "db/migrate/20190730153555_recreate_structure.rb"
@ -644,6 +644,9 @@ Performance/RedundantMatch:
Performance/RedundantMerge: Performance/RedundantMerge:
Enabled: true Enabled: true
Style/HashTransformValues:
Enabled: true
Style/RedundantSortBy: Style/RedundantSortBy:
Enabled: true Enabled: true
@ -1373,4 +1376,3 @@ Style/YodaCondition:
Style/ZeroLengthPredicate: Style/ZeroLengthPredicate:
Enabled: true Enabled: true

View file

@ -111,7 +111,8 @@ group :development do
gem 'rack-mini-profiler' gem 'rack-mini-profiler'
gem 'rails-erd', require: false # generates `doc/database_models.pdf` gem 'rails-erd', require: false # generates `doc/database_models.pdf`
gem 'rubocop', require: false gem 'rubocop', require: false
gem 'rubocop-rails_config' gem 'rubocop-performance', require: false
gem 'rubocop-rails', require: false
gem 'rubocop-rspec-focused', require: false gem 'rubocop-rspec-focused', require: false
gem 'scss_lint', require: false gem 'scss_lint', require: false
gem 'web-console' gem 'web-console'

View file

@ -620,8 +620,6 @@ GEM
unicode-display_width (>= 1.4.0, < 3.0) unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1) rubocop-ast (1.4.1)
parser (>= 2.7.1.5) parser (>= 2.7.1.5)
rubocop-packaging (0.5.1)
rubocop (>= 0.89, < 2.0)
rubocop-performance (1.9.2) rubocop-performance (1.9.2)
rubocop (>= 0.90.0, < 2.0) rubocop (>= 0.90.0, < 2.0)
rubocop-ast (>= 0.4.0) rubocop-ast (>= 0.4.0)
@ -629,13 +627,6 @@ GEM
activesupport (>= 4.2.0) activesupport (>= 4.2.0)
rack (>= 1.1) rack (>= 1.1)
rubocop (>= 0.90.0, < 2.0) rubocop (>= 0.90.0, < 2.0)
rubocop-rails_config (1.3.1)
railties (>= 5.0)
rubocop (>= 1.8)
rubocop-ast (>= 1.0.1)
rubocop-packaging (~> 0.5)
rubocop-performance (~> 1.3)
rubocop-rails (~> 2.0)
rubocop-rspec-focused (1.0.0) rubocop-rspec-focused (1.0.0)
rubocop (>= 0.51) rubocop (>= 0.51)
ruby-graphviz (1.2.5) ruby-graphviz (1.2.5)
@ -874,7 +865,8 @@ DEPENDENCIES
rspec-rails rspec-rails
rspec_junit_formatter rspec_junit_formatter
rubocop rubocop
rubocop-rails_config rubocop-performance
rubocop-rails
rubocop-rspec-focused rubocop-rspec-focused
ruby-saml-idp ruby-saml-idp
sanitize-url sanitize-url