DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

app: use password_complexity in Administrateurs::ActivateController

Browse source
This commit is contained in:
Pierre de La Morinerie 2021-08-31 16:15:08 +00:00
parent 428ca8755f
commit ed8b19d2eb
3 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/views/administrateurs/activate/new.html.haml
View file

@ -16,7 +16,6 @@
= f.label :password do = f.label :password do
Mot de passe Mot de passe
= render 'password_complexity/field', { form: f, test_complexity: true }
= render partial: 'shared/password/edit_password', locals: { form: f, controller: 'administrateurs/passwords' }
= f.submit 'Continuer', class: 'button large primary expand', id: "submit-password", data: { disable_with: "Envoi..." } = f.submit 'Continuer', class: 'button large primary expand', id: "submit-password", data: { disable_with: "Envoi..." }

4
config/routes.rb
View file

@ -110,10 +110,6 @@ Rails.application.routes.draw do
get '/users/password/reset-link-sent' => 'users/passwords#reset_link_sent' get '/users/password/reset-link-sent' => 'users/passwords#reset_link_sent'
end end
devise_scope :administrateur do
get '/administrateurs/password/test_strength' => 'administrateurs/passwords#test_strength'
end
get 'password_complexity' => 'password_complexity#show', as: 'show_password_complexity' get 'password_complexity' => 'password_complexity#show', as: 'show_password_complexity'
# #

13
spec/features/admin/admin_creation_spec.rb
View file

@ -2,6 +2,8 @@ feature 'As an administrateur', js: true do
let(:super_admin) { create(:super_admin) } let(:super_admin) { create(:super_admin) }
let(:admin_email) { 'new_admin@gouv.fr' } let(:admin_email) { 'new_admin@gouv.fr' }
let(:new_admin) { Administrateur.by_email(admin_email) } let(:new_admin) { Administrateur.by_email(admin_email) }
let(:weak_password) { '12345678' }
let(:strong_password) { 'a new, long, and complicated password!' }
before do before do
perform_enqueued_jobs do perform_enqueued_jobs do
@ -9,14 +11,21 @@ feature 'As an administrateur', js: true do
end end
end end
scenario 'I can register' do scenario 'I can register', js: true do
expect(new_admin.reload.user.active?).to be(false) expect(new_admin.reload.user.active?).to be(false)
confirmation_email = open_email(admin_email) confirmation_email = open_email(admin_email)
token_params = confirmation_email.body.match(/token=[^"]+/) token_params = confirmation_email.body.match(/token=[^"]+/)
visit "admin/activate?#{token_params}" visit "admin/activate?#{token_params}"
fill_in :administrateur_password, with: 'my-s3cure-p4ssword' fill_in :administrateur_password, with: weak_password
expect(page).to have_text('Mot de passe très vulnérable')
expect(page).to have_button('Continuer', disabled: true)
fill_in :administrateur_password, with: strong_password
expect(page).to have_text('Mot de passe suffisamment fort et sécurisé')
expect(page).to have_button('Continuer', disabled: false)
click_button 'Continuer' click_button 'Continuer'