DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

poc(batch_operation): some rewrite to avoid various conflict (when an instructeur try to create a job with an incompatible dossier regarding the current task). also soome cleanup to isole spec in least involved model

Browse source
This commit is contained in:
Martin 2022-11-25 15:43:00 +01:00 • committed by mfo
parent 4266ab93c5
commit eaf72162da
8 changed files with 240 additions and 129 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/controllers/instructeurs/batch_operations_controller.rb
View file

@ -4,10 +4,7 @@ module Instructeurs
before_action :ensure_ownership!
def create
ActiveRecord::Base.transaction do
batch_operation = BatchOperation.create!(batch_operation_params.merge(instructeur: current_instructeur))
BatchOperationEnqueueAllJob.perform_later(batch_operation)
end
BatchOperation.safe_create!(batch_operation_params.merge(instructeur: current_instructeur))
redirect_back(fallback_location: instructeur_procedure_url(@procedure.id))
end
@ -15,9 +12,7 @@ module Instructeurs
def batch_operation_params
params.require(:batch_operation)
.permit(:operation, dossier_ids: []).tap do |params|
# TODO: filter dossiers_ids out of instructeurs.dossiers.ids
end
.permit(:operation, dossier_ids: [])
end
def set_procedure