Merge pull request #2060 from betagouv/fix-bug

Forgot to change a local variable into an instance variable

app/controllers/users/registrations_controller.rb

@@ -17,7 +17,7 @@ class Users::RegistrationsController < Devise::RegistrationsController
   def create
     user = User.find_by(email: params[:user][:email])
     if user.present?
-      UserMailer.new_account_warning(user).deliver
+      UserMailer.new_account_warning(user).deliver_later
       flash.notice = t('devise.registrations.signed_up_but_unconfirmed')
       redirect_to root_path
     else

app/mailers/user_mailer.rb

@@ -5,6 +5,6 @@ class UserMailer < ApplicationMailer
     @user = user
     @subject = "Demande de création de compte"
 
-    mail(to: user.email, subject: subject)
+    mail(to: user.email, subject: @subject)
   end
 end

spec/controllers/users/registrations_controller_spec.rb

@@ -37,7 +37,7 @@ describe Users::RegistrationsController, type: :controller do
       let!(:existing_user) { create(:user, email: email, password: password) }
 
       before do
-        allow(UserMailer).to receive(:new_account_warning).and_return(double(deliver: 'deliver'))
+        allow(UserMailer).to receive(:new_account_warning).and_return(double(deliver_later: 'deliver'))
         subject
       end