tech(refactor): much nicer code, thx LeSim

root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
This commit is contained in:
simon lehericey 2023-04-14 10:55:36 +02:00 committed by mfo
parent cc2c856ec2
commit e64ac79f05
16 changed files with 139 additions and 109 deletions

View file

@ -42,5 +42,5 @@
= f.select :groupe_instructeur_id,
dossier.procedure.groupe_instructeurs.active.map { |gi| [gi.label, gi.id] },
{ include_blank: dossier.brouillon? }
= render EditableChamp::ChampsTreeComponent.new(champs: dossier.champs_public, root_depth: 0)
= render EditableChamp::SectionComponent.new(champs: dossier.champs_public)
= render Dossiers::EditFooterComponent.new(dossier: dossier, annotation: false)

View file

@ -3,7 +3,7 @@
%section.counter-start-header-section
= render NestedForms::FormOwnerComponent.new
= form_for dossier, url: annotations_instructeur_dossier_path(dossier.procedure, dossier), html: { class: 'form', multipart: true } do |f|
= render EditableChamp::ChampsTreeComponent.new(champs: dossier.champs_private, root_depth: 0)
= render EditableChamp::SectionComponent.new(champs: dossier.champs_private)
= render Dossiers::EditFooterComponent.new(dossier: dossier, annotation: true)
- else