DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #5031 from betagouv/remove-jquery-bookkeeping

Browse source 
javascript: remove unused jQuery.active bookkeeping
This commit is contained in:
Pierre de La Morinerie 2020-04-09 18:03:03 +02:00 committed by GitHub
commit e45d56c681
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/javascript/shared/rails-ujs-fix.js
View file

@ -1,20 +1,5 @@
import Rails from '@rails/ujs'; import Rails from '@rails/ujs';
import jQuery from 'jquery'; import jQuery from 'jquery';
import { delegate } from '@utils';
// We use `jQuery.active` in our capybara suit to wait for ajax requests.
// Newer jQuery-less version of rails-ujs is breaking it.
// We have to set `ajax:complete` listener on the same element as the one
// we catch ajax:send on as by the end of the request
// the old element may be removed from DOM.
delegate('ajax:send', '[data-remote]', ({ target }) => {
let callback = () => {
jQuery.active--;
target.removeEventListener('ajax:complete', callback);
};
target.addEventListener('ajax:complete', callback);
jQuery.active++;
});
// `smart_listing` gem is overriding `$.rails.href` method. When using newer // `smart_listing` gem is overriding `$.rails.href` method. When using newer
// jQuery-less version of rails-ujs it breaks. // jQuery-less version of rails-ujs it breaks.