Enable Style/SymbolProc

.rubocop.yml

@@ -1205,7 +1205,8 @@ Style/SymbolLiteral:
   Enabled: false
 
 Style/SymbolProc:
-  Enabled: false
+  Enabled: true
+  IgnoredMethods: [after]
 
 Style/TernaryParentheses:
   Enabled: false

app/controllers/france_connect/particulier_controller.rb

@@ -10,7 +10,7 @@ class FranceConnect::ParticulierController < ApplicationController
 
     fci = FranceConnectInformation
       .find_by(france_connect_particulier_id: fetched_fci[:france_connect_particulier_id]) ||
-        fetched_fci.tap { |object| object.save }
+        fetched_fci.tap(&:save)
 
     if fci.user.nil?
       user = User.find_or_create_by(email: fci.email_france_connect) do |new_user|

app/controllers/new_user/demarches_controller.rb

@@ -6,7 +6,7 @@ module NewUser
         .includes(:procedure)
         .map(&:procedure)
         .uniq
-        .select { |p| p.publiee? }
+        .select(&:publiee?)
 
       @popular_demarches = Procedure
         .includes(:service)

app/jobs/administrateurs/activate_before_expiration_job.rb

@@ -2,8 +2,6 @@ class Administrateurs::ActivateBeforeExpirationJob < ApplicationJob
   queue_as :cron
 
   def perform(*args)
-    Administrateur.inactive.where(created_at: 3.days.ago.all_day).each do |a|
+    Administrateur.inactive.where(created_at: 3.days.ago.all_day).each(&:remind_invitation!)
-      a.remind_invitation!
-    end
   end
 end

app/jobs/auto_archive_procedure_job.rb

@@ -3,9 +3,7 @@ class AutoArchiveProcedureJob < ApplicationJob
 
   def perform(*args)
     Procedure.publiees.where("auto_archive_on <= ?", Date.today).each do |procedure|
-      procedure.dossiers.state_en_construction.each do |dossier|
+      procedure.dossiers.state_en_construction.each(&:en_instruction!)
-        dossier.en_instruction!
-      end
 
       procedure.archive!
     end

app/services/champs_service.rb

@@ -14,7 +14,7 @@ class ChampsService
     def check_piece_justificative_files(champs)
       champs.select do |champ|
         champ.type_champ == TypeDeChamp.type_champs.fetch(:piece_justificative)
-      end.map { |c| c.piece_justificative_file_errors }.flatten
+      end.map(&:piece_justificative_file_errors).flatten
     end
 
     private

app/services/types_de_champ_service.rb

@@ -70,6 +70,6 @@ class TypesDeChampService
   end
 
   def self.clean_value(value)
-    value.split("\r\n").map{ |v| v.strip }.join("\r\n")
+    value.split("\r\n").map(&:strip).join("\r\n")
   end
 end

db/migrate/20160802113112_build_default_preference_list_dossier.rb

@@ -124,9 +124,7 @@ class BuildDefaultPreferenceListDossier < ActiveRecord::Migration
   end
 
   def up
-    Gestionnaire.all.each do |gestionnaire|
+    Gestionnaire.all.each(&:build_default_preferences_list_dossier)
-      gestionnaire.build_default_preferences_list_dossier
-    end
   end
 
   def down

db/migrate/20161007095443_reset_all_preference_list_dossier.rb

@@ -159,8 +159,6 @@ class ResetAllPreferenceListDossier < ActiveRecord::Migration
       end
     end
 
-    Gestionnaire.all.each do |gestionnaire|
+    Gestionnaire.all.each(&:build_default_preferences_list_dossier)
-      gestionnaire.build_default_preferences_list_dossier
-    end
   end
 end

db/migrate/20170215102943_remove_duplicate_email_received.rb

@@ -1,7 +1,7 @@
 class RemoveDuplicateEmailReceived < ActiveRecord::Migration[5.0]
   def change
     all_mails = MailReceived.all
-    groupped = all_mails.group_by { |m| m.procedure_id }
+    groupped = all_mails.group_by(&:procedure_id)
     filtered = groupped.reject { |k, v| v.length < 2 }
     filtered.each_value do |duplicate_mails|
       duplicate_mails.pop

lib/cellar/cellar_adapter.rb

@@ -119,7 +119,7 @@ module Cellar
         doc = Nokogiri::XML(bucket_listing_xml)
         doc
           .xpath('//xmlns:Contents/xmlns:Key')
-          .map{ |k| k.text }
+          .map(&:text)
       end
 
       def bulk_deletion_request_body(keys)

lib/mailers/attestation_closed_mail_discrepancy_mailer.rb

@@ -13,7 +13,7 @@ module Mailers
       if procedures.count == 1
         procedure_ids = "votre démarche nº #{procedures.first.id}"
       else
-        procedure_ids = 'vos démarches nº ' + procedures.map{ |p| p.id }.join(', ')
+        procedure_ids = 'vos démarches nº ' + procedures.map(&:id).join(', ')
       end
       "demarches-simplifiees.fr – mise à jour nécessaire de l’accusé d’acceptation de #{procedure_ids}"
     end

lib/tasks/2018_01_18_clean_datetime_in_champs.rake

@@ -2,7 +2,7 @@ require Rails.root.join("lib", "tasks", "task_helper")
 
 namespace :'2018_01_18_clean_datetime_in_champs' do
   task clean: :environment do
-    datetime_champs = TypeDeChamp.where(type_champ: "datetime").flat_map{ |t| t.champ }
+    datetime_champs = TypeDeChamp.where(type_champ: "datetime").flat_map(&:champ)
 
     # Match " HH:MM" => nil a datetime is not valid if not composed by date AND time
     datetime_champs.select { |c| /^\s\d{2}:\d{2}$/.match(c.value) }.each do |c|

lib/tasks/2018_06_04_scan_pjs.rake

@@ -1,7 +1,5 @@
 namespace :'2018_06_04_scan_pjs' do
   task scan_all: :environment do
-    Champs::PieceJustificativeChamp.all.each do |pj_champ|
+    Champs::PieceJustificativeChamp.all.each(&:create_virus_scan)
-      pj_champ.create_virus_scan
-    end
   end
 end

lib/tasks/2018_06_06_users_for_admins_and_gestionnaires.rake

@@ -3,7 +3,7 @@ require Rails.root.join("lib", "tasks", "task_helper")
 namespace :'2018_06_06_users_for_admins_and_gestionnaires' do
   task preactivate: :environment do
     preactivate_users(Gestionnaire, 'accompagnateur') { |g| g.reset_password_token.nil? }
-    preactivate_users(Administrateur) { |a| a.active? }
+    preactivate_users(Administrateur, &:active?)
   end
 
   def preactivate_users(model, role_name = nil, &block)

lib/tasks/support.rake

@@ -45,7 +45,7 @@ namespace :support do
     if user.dossiers.state_instruction_commencee.any?
       fail "Cannot delete this user because instruction has started for some dossiers"
     end
-    user.dossiers.each { |d| d.delete_and_keep_track }
+    user.dossiers.each(&:delete_and_keep_track)
     user.destroy
   end
 end