Simplify API carte serializer

This commit is contained in:
Paul Chavard 2018-11-27 15:55:14 +01:00
parent 36f6f54337
commit d988638c58
6 changed files with 18 additions and 83 deletions

View file

@ -11,7 +11,7 @@ class ChampSerializer < ActiveModel::Serializer
def value
case object
when GeoArea, UserGeometry, Cadastre, QuartierPrioritaire
when GeoArea
object.geometry
when Champs::CarteChamp
if object.value.present?
@ -40,7 +40,7 @@ class ChampSerializer < ActiveModel::Serializer
def type_de_champ
case object
when GeoArea, UserGeometry, Cadastre, QuartierPrioritaire
when GeoArea
legacy_type_de_champ
else
object.type_de_champ
@ -76,28 +76,18 @@ class ChampSerializer < ActiveModel::Serializer
end
def legacy_carto_libelle
case object
when UserGeometry, Cadastre, QuartierPrioritaire
object.class.name.underscore.tr('_', ' ')
if object.source == GeoArea.sources.fetch(:selection_utilisateur)
'user geometry'
else
if object.source == GeoArea.sources.fetch(:selection_utilisateur)
'user geometry'
else
object.source.to_s.tr('_', ' ')
end
object.source.to_s.tr('_', ' ')
end
end
def legacy_carto_type_champ
case object
when UserGeometry, Cadastre, QuartierPrioritaire
object.class.name.underscore
if object.source == GeoArea.sources.fetch(:selection_utilisateur)
'user_geometry'
else
if object.source == GeoArea.sources.fetch(:selection_utilisateur)
'user_geometry'
else
object.source.to_s
end
object.source.to_s
end
end
end

View file

@ -28,14 +28,7 @@ class DossierSerializer < ActiveModel::Serializer
def champs
champs = object.champs.to_a
if object.use_legacy_carto?
champs += object.quartier_prioritaires
champs += object.cadastres
if object.user_geometry.present?
champs << object.user_geometry
end
elsif object.expose_legacy_carto_api?
if object.expose_legacy_carto_api?
champ_carte = champs.find do |champ|
champ.type_de_champ.type_champ == TypeDeChamp.type_champs.fetch(:carte)
end

View file

@ -37,6 +37,10 @@ class ProcedureSerializer < ActiveModel::Serializer
end
def geographic_information
object.module_api_carto
if object.expose_legacy_carto_api?
object.module_api_carto
else
ModuleAPICarto.new(procedure: object)
end
end
end