DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Bump development gems

Browse source 
- brakeman
- rubocop
- scss_lint
This commit is contained in:
gregoirenovel 2018-03-02 16:27:03 +01:00
parent 1030a4ae7d
commit d6ad3fc3fd
42 changed files with 99 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/admin/attestation_templates_controller.rb
View file

@ -8,7 +8,7 @@ class Admin::AttestationTemplatesController < AdminController
def update
attestation_template = @procedure.attestation_template
if attestation_template.update_attributes(activated_attestation_params)
if attestation_template.update(activated_attestation_params)
flash.notice = "L'attestation a bien été modifiée"
else
flash.alert = attestation_template.errors.full_messages.join('<br>')

2
app/controllers/admin/mail_templates_controller.rb
View file

@ -11,7 +11,7 @@ class Admin::MailTemplatesController < AdminController
def update
mail_template = find_mail_template_by_slug(params[:id])
mail_template.update_attributes(update_params)
mail_template.update(update_params)
redirect_to admin_procedure_mail_templates_path
end

2
app/controllers/admin/pieces_justificatives_controller.rb
View file

@ -6,7 +6,7 @@ class Admin::PiecesJustificativesController < AdminController
end
def update
if @procedure.update_attributes(update_params)
if @procedure.update(update_params)
flash.now.notice = 'Modifications sauvegardées'
else
flash.now.notice = 'Une erreur est survenue'

2
app/controllers/admin/procedures_controller.rb
View file

@ -105,7 +105,7 @@ class Admin::ProceduresController < AdminController
def update
@procedure = current_administrateur.procedures.find(params[:id])
if !@procedure.update_attributes(procedure_params)
if !@procedure.update(procedure_params)
flash.now.alert = @procedure.errors.full_messages
return render 'edit'
end

2
app/controllers/admin/types_de_champ_controller.rb
View file

@ -15,7 +15,7 @@ class Admin::TypesDeChampController < AdminController
end
def update
@procedure.update_attributes(TypesDeChampService.create_update_procedure_params params)
@procedure.update(TypesDeChampService.create_update_procedure_params params)
create_facade
flash.now.notice = 'Modifications sauvegardées'
render 'show', format: :js

2
app/controllers/admin/types_de_champ_private_controller.rb
View file

@ -16,7 +16,7 @@ class Admin::TypesDeChampPrivateController < AdminController
end
def update
@procedure.update_attributes(TypesDeChampService.create_update_procedure_params params, true)
@procedure.update(TypesDeChampService.create_update_procedure_params params, true)
create_facade
flash.now.notice = 'Modifications sauvegardées'
render 'admin/types_de_champ/show', format: :js

2
app/controllers/new_gestionnaire/avis_controller.rb
View file

@ -32,7 +32,7 @@ module NewGestionnaire
end
def update
avis.update_attributes(avis_params)
avis.update(avis_params)
flash.notice = 'Votre réponse est enregistrée.'
redirect_to instruction_gestionnaire_avis_path(avis)
end

6
app/controllers/new_gestionnaire/dossiers_controller.rb
View file

@ -57,13 +57,13 @@ module NewGestionnaire
end
def archive
dossier.update_attributes(archived: true)
dossier.update(archived: true)
current_gestionnaire.unfollow(dossier)
redirect_back(fallback_location: gestionnaire_procedures_url)
end
def unarchive
dossier.update_attributes(archived: false)
dossier.update(archived: false)
redirect_back(fallback_location: gestionnaire_procedures_url)
end
@ -166,7 +166,7 @@ module NewGestionnaire
def update_annotations
dossier = current_gestionnaire.dossiers.includes(champs_private: :type_de_champ).find(params[:dossier_id])
# FIXME: add attachements validation, cf. Champ#piece_justificative_file_errors
dossier.update_attributes(champs_private_params)
dossier.update(champs_private_params)
redirect_to annotations_privees_gestionnaire_dossier_path(procedure, dossier)
end

11
app/controllers/new_gestionnaire/procedures_controller.rb
View file

@ -109,11 +109,11 @@ module NewGestionnaire
c.to_json
end
procedure_presentation.update_attributes(displayed_fields: fields)
procedure_presentation.update(displayed_fields: fields)
current_sort = procedure_presentation.sort
if !values.include?("#{current_sort['table']}/#{current_sort['column']}")
procedure_presentation.update_attributes(sort: Procedure.default_sort)
procedure_presentation.update(sort: Procedure.default_sort)
end
redirect_back(fallback_location: gestionnaire_procedure_url(procedure))
@ -136,7 +136,7 @@ module NewGestionnaire
'order' => order
}.to_json
procedure_presentation.update_attributes(sort: sort)
procedure_presentation.update(sort: sort)
redirect_back(fallback_location: gestionnaire_procedure_url(procedure))
end
@ -154,7 +154,7 @@ module NewGestionnaire
'value' => params[:value]
}
procedure_presentation.update_attributes(filters: filters.to_json)
procedure_presentation.update(filters: filters.to_json)
end
redirect_back(fallback_location: gestionnaire_procedure_url(procedure))
@ -168,7 +168,7 @@ module NewGestionnaire
filters[statut] = filters[statut] - [filter_to_remove]
procedure_presentation.update_attributes(filters: filters.to_json)
procedure_presentation.update(filters: filters.to_json)
redirect_back(fallback_location: gestionnaire_procedure_url(procedure))
end
@ -245,7 +245,6 @@ module NewGestionnaire
.includes(filter['table'])
.where("#{filter['table'].pluralize}.#{filter['column']} LIKE ?", "%#{filter['value']}%")
end
end.pluck(:id)
end.reduce(:&)
end

2
app/controllers/users/carte_controller.rb
View file

@ -22,7 +22,7 @@ class Users::CarteController < UsersController
ModuleApiCartoService.save_cadastre! dossier, params[:json_latlngs]
end
dossier.update_attributes(json_latlngs: params[:json_latlngs])
dossier.update(json_latlngs: params[:json_latlngs])
redirect_to modifier_dossier_path(dossier)
end

4
app/controllers/users/dossiers_controller.rb
View file

@ -156,7 +156,7 @@ class Users::DossiersController < UsersController
flash.alert = individual_errors
redirect_to users_dossier_path(id: @facade.dossier.id)
else
if !Dossier.find(@facade.dossier.id).update_attributes update_params_with_formatted_birthdate
if !Dossier.find(@facade.dossier.id).update update_params_with_formatted_birthdate
flash.alert = @facade.dossier.errors.full_messages
return redirect_to users_dossier_path(id: @facade.dossier.id)
@ -259,7 +259,7 @@ class Users::DossiersController < UsersController
end
def update_current_user_siret! siret
current_user.update_attributes(siret: siret)
current_user.update(siret: siret)
end
def facade id = params[:id]

4
app/controllers/users/sessions_controller.rb
View file

@ -20,7 +20,7 @@ class Users::SessionsController < Sessions::SessionsController
try_to_authenticate(Administrateur, remember_me)
if user_signed_in?
current_user.update_attributes(loged_in_with_france_connect: '')
current_user.update(loged_in_with_france_connect: '')
end
if user_signed_in?
@ -44,7 +44,7 @@ class Users::SessionsController < Sessions::SessionsController
if user_signed_in?
connected_with_france_connect = current_user.loged_in_with_france_connect
current_user.update_attributes(loged_in_with_france_connect: '')
current_user.update(loged_in_with_france_connect: '')
sign_out :user