DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Try to reduce the number of external data fetches

Browse source 
Only fetch external data if the external_id is the current one and data is not yet fetched
This commit is contained in:
Paul Chavard 2021-03-11 12:32:08 +01:00
parent 21d5da379f
commit d24ee27cac
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/jobs/champ_fetch_external_data_job.rb
View file

@ -1,6 +1,6 @@
class ChampFetchExternalDataJob < ApplicationJob class ChampFetchExternalDataJob < ApplicationJob
def perform(champ) def perform(champ, external_id)
if champ.external_id.present? if champ.external_id == external_id && champ.data.nil?
data = champ.fetch_external_data data = champ.fetch_external_data
if data.present? if data.present?

2
app/models/champ.rb
View file

@ -171,7 +171,7 @@ class Champ < ApplicationRecord
def fetch_external_data_later def fetch_external_data_later
if fetch_external_data? && external_id.present? && data.nil? if fetch_external_data? && external_id.present? && data.nil?
ChampFetchExternalDataJob.perform_later(self) ChampFetchExternalDataJob.perform_later(self, external_id)
end end
end end