DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #8084 from colinux/view-components-haml-lint

Browse source 
linters: enable haml-lint for View components
This commit is contained in:
Colin Darie 2022-11-22 12:16:07 +01:00 committed by GitHub
commit d1de20e628
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/components/dsfr/card_vertical_component/card_vertical_component.html.haml
View file

@ -12,11 +12,11 @@
%ul.fr-tags-group %ul.fr-tags-group
- tags.each do |tag| - tags.each do |tag|
%li %li
%p.fr-tag=tag %p.fr-tag= tag
.fr-card__end .fr-card__end
- if error - if error
.fr-card__detail.fr-alert.fr-alert--error .fr-card__detail.fr-alert.fr-alert--error
%p=error %p= error
- if footer_buttons? - if footer_buttons?
.fr-card__footer .fr-card__footer

4
app/components/editable_champ/explication_component/explication_component.html.haml
View file

@ -6,6 +6,6 @@
- if @champ.collapsible_explanation_enabled? && @champ.collapsible_explanation_text.present? - if @champ.collapsible_explanation_enabled? && @champ.collapsible_explanation_text.present?
%div %div
%p.fr-my-2w %p.fr-my-2w
%button{type: "button", "aria-controls": dom_id(@champ, :explanation), "aria-expanded": "false", href: dom_id(@champ, :explanation)} Lire plus %button{ type: "button", "aria-controls": dom_id(@champ, :explanation), "aria-expanded": "false", href: dom_id(@champ, :explanation) } Lire plus
%p.fr-collapse{ id: dom_id(@champ, :explanation)} %p.fr-collapse{ id: dom_id(@champ, :explanation) }
= @champ.collapsible_explanation_text = @champ.collapsible_explanation_text

2
app/components/types_de_champ_editor/champ_component/champ_component.html.haml
View file

@ -1,5 +1,5 @@
%li.type-de-champ.flex.column.justify-start{ html_options } %li.type-de-champ.flex.column.justify-start{ html_options }
.flex.justify-start.section.head{ class: type_de_champ.header_section? ? '' : 'hr'} .flex.justify-start.section.head{ class: type_de_champ.header_section? ? '' : 'hr' }
.handle.small.icon-only.icon.move-handle{ title: "Déplacer le champ vers le haut ou vers le bas" } .handle.small.icon-only.icon.move-handle{ title: "Déplacer le champ vers le haut ou vers le bas" }
.flex.justify-start.delete .flex.justify-start.delete
= button_to type_de_champ_path, class: 'button small icon-only danger', method: :delete, form: { data: { turbo_confirm: 'Êtes vous sûr de vouloir supprimer ce champ ?' } } do = button_to type_de_champ_path, class: 'button small icon-only danger', method: :delete, form: { data: { turbo_confirm: 'Êtes vous sûr de vouloir supprimer ce champ ?' } } do

2
app/components/types_de_champ_editor/estimated_fill_duration_component/estimated_fill_duration_component.html.haml
View file

@ -1,5 +1,5 @@
%span.fill-duration{ id: dom_id(@revision, :estimated_fill_duration) } %span.fill-duration{ id: dom_id(@revision, :estimated_fill_duration) }
- if show? - if show?
= t('.estimated_fill_duration') = t('.estimated_fill_duration')
= link_to "https://doc.demarches-simplifiees.fr/tutoriels/tutoriel-administrateur#g.-estimation-de-la-duree-de-remplissage", target: "_blank", rel: "noopener noreferrer" do = link_to "#{DOC_URL}/tutoriels/tutoriel-administrateur#g.-estimation-de-la-duree-de-remplissage", target: "_blank", rel: "noopener noreferrer" do
= t('.estimated_fill_minutes', estimated_minutes: estimated_fill_duration_minutes) = t('.estimated_fill_minutes', estimated_minutes: estimated_fill_duration_minutes)

2
lib/tasks/lint.rake
View file

@ -1,6 +1,6 @@
task :lint do task :lint do
sh "bundle exec rubocop --parallel" sh "bundle exec rubocop --parallel"
sh "bundle exec haml-lint app/views/" sh "bundle exec haml-lint app/views/ app/components/"
sh "bundle exec scss-lint app/assets/stylesheets/" sh "bundle exec scss-lint app/assets/stylesheets/"
sh "bundle exec i18n-tasks missing --locales fr" sh "bundle exec i18n-tasks missing --locales fr"
sh "bundle exec i18n-tasks unused --locale en" # TODO: check for all locales sh "bundle exec i18n-tasks unused --locale en" # TODO: check for all locales