DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(api-entreprise): do not crash when siret not found

Browse source
This commit is contained in:
Paul Chavard 2023-04-05 18:38:13 +02:00
parent 6511836f2d
commit d1d5bc2e67
2 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/lib/api_entreprise/entreprise_adapter.rb
View file

@ -6,7 +6,14 @@ class APIEntreprise::EntrepriseAdapter < APIEntreprise::Adapter
end end
def process_params def process_params
params = data_source[:entreprise]&.slice(*attr_to_fetch) params = data_source[:entreprise]
return {} if params.nil?
Sentry.with_scope do |scope|
scope.set_tags(siret: @siret)
scope.set_extras(source: params)
params = params.slice(*attr_to_fetch)
params[:etat_administratif] = map_etat_administratif(data_source) params[:etat_administratif] = map_etat_administratif(data_source)
if params.present? && valid_params?(params) if params.present? && valid_params?(params)
@ -19,6 +26,7 @@ class APIEntreprise::EntrepriseAdapter < APIEntreprise::Adapter
{} {}
end end
end end
end
def attr_to_fetch def attr_to_fetch
[ [

3
app/lib/api_entreprise/rna_adapter.rb
View file

@ -15,12 +15,13 @@ class APIEntreprise::RNAAdapter < APIEntreprise::Adapter
def process_params def process_params
params = data_source[:association] params = data_source[:association]
return {} if params.nil?
Sentry.with_scope do |scope| Sentry.with_scope do |scope|
scope.set_tags(siret: @siret) scope.set_tags(siret: @siret)
scope.set_extras(source: params) scope.set_extras(source: params)
params = params&.slice(*attr_to_fetch) if @depreciated params = params.slice(*attr_to_fetch) if @depreciated
params[:rna] = data_source.dig(:association, :id) params[:rna] = data_source.dig(:association, :id)
if params[:rna].present? && valid_params?(params) if params[:rna].present? && valid_params?(params)