Merge pull request #3373 from betagouv/reinforce-clamav-service-response

If ClamavService fails then raise an error
This commit is contained in:
LeSim 2019-02-05 18:03:41 +01:00 committed by GitHub
commit c8b11b621f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 9 deletions

View file

@ -1,15 +1,21 @@
class ClamavService class ClamavService
def self.safe_file?(file_path) def self.safe_file?(file_path)
if Rails.env.development? if Rails.env.development?
Rails.logger.info("Rails.env = development => fake scan") # FIXME : remove me
return true return true
end end
FileUtils.chmod(0666, file_path) FileUtils.chmod(0666, file_path)
client = ClamAV::Client.new client = ClamAV::Client.new
response = client.execute(ClamAV::Commands::ScanCommand.new(file_path)) response = client.execute(ClamAV::Commands::ScanCommand.new(file_path)).first
Rails.logger.info("ClamAV response for #{file_path} : #{response.first.class.name}") # FIXME : remove me if response.class == ClamAV::SuccessResponse
response.first.class != ClamAV::VirusResponse true
elsif response.class == ClamAV::VirusResponse
false
elsif response.class == ClamAV::ErrorResponse
raise "ClamAV ErrorResponse : #{response.error_str}"
else
raise "ClamAV unkown response #{response.class.name}"
end
end end
end end

View file

@ -4,17 +4,27 @@ describe ClamavService do
describe '.safe_file?' do describe '.safe_file?' do
let(:path_file) { '/tmp/plop.txt' } let(:path_file) { '/tmp/plop.txt' }
subject { ClamavService.safe_file? path_file } subject { ClamavService.safe_file?(path_file) }
before do before do
client = instance_double("ClamAV::Client", :execute => [ClamAV::SuccessResponse]) client = double("ClamAV::Client", execute: [response])
allow(ClamAV::Client).to receive(:new).and_return(client) allow(ClamAV::Client).to receive(:new).and_return(client)
end
it 'change permission of file path' do
allow(FileUtils).to receive(:chmod).with(0666, path_file).and_return(true) allow(FileUtils).to receive(:chmod).with(0666, path_file).and_return(true)
end
subject context 'When response type is ClamAV::SuccessResponse' do
let(:response) { ClamAV::SuccessResponse.new("OK") }
it { expect(subject).to eq(true) }
end
context 'When response type is ClamAV::VirusResponse' do
let(:response) { ClamAV::VirusResponse.new("KO", "VirusN4ame") }
it { expect(subject).to eq(false) }
end
context 'When response type is ClamAV::ErrorResponse' do
let(:response) { ClamAV::ErrorResponse.new("File not found") }
it { expect { subject }.to raise_error("ClamAV ErrorResponse : File not found") }
end end
end end
end end