Merge pull request #475 from sgmap/474_display_devise_errors_with_flashes

474 display devise errors with flashes

app/controllers/backoffice/avis_controller.rb

@@ -49,7 +49,7 @@ class Backoffice::AvisController < ApplicationController
       avis = Avis.find(params[:id])
       redirect_to url_for(backoffice_dossier_path(avis.dossier_id))
     else
-      flash[:alert] = gestionnaire.errors.full_messages.join('<br>')
+      flash[:alert] = gestionnaire.errors.full_messages
       redirect_to url_for(avis_sign_up_path(params[:id], email))
     end
   end

app/controllers/backoffice/private_formulaires_controller.rb

@@ -11,7 +11,7 @@ class Backoffice::PrivateFormulairesController < ApplicationController
       if champs_service_errors.empty?
         flash[:notice] = "Formulaire enregistré"
       else
-        flash[:alert] = champs_service_errors.join('<br>').html_safe
+        flash[:alert] = champs_service_errors
       end
     end
 

app/helpers/application_helper.rb

@@ -0,0 +1,8 @@
+module ApplicationHelper
+  def flash_class(level)
+    case level
+    when "notice" then "alert-success"
+    when "alert" then "alert-danger"
+    end
+  end
+end

app/helpers/devise_helper.rb

@@ -0,0 +1,8 @@
+module DeviseHelper
+  def devise_error_messages!
+    if resource.errors.full_messages.any?
+      flash.now[:alert] = resource.errors.full_messages
+    end
+    ''
+  end
+end

app/views/layouts/_flash_messages.html.haml

@@ -1,8 +1,11 @@
-- if flash.notice.present? || flash.alert.present?
+- if flash.any?
   #flash_message.center
-    - if flash.notice.present?
+    - flash.each do |key, value|
-      .alert.alert-success
+      - if value.class == Array
-        = flash.notice
+        .alert{ class: flash_class(key) }
-    - if flash.alert.present?
+          - value.each do |message|
-      .alert.alert-danger
+            = message
-        = flash.alert.html_safe
+            %br
+      - else
+        .alert{ class: flash_class(key) }
+          = value

spec/controllers/backoffice/avis_controller_spec.rb

@@ -178,7 +178,7 @@ describe Backoffice::AvisController, type: :controller do
 
         it { expect(created_gestionnaire).to be_nil }
         it { is_expected.to redirect_to avis_sign_up_path(avis_id, invited_email) }
-        it { expect(flash.alert).to eq('Password : Le mot de passe est vide') }
+        it { expect(flash.alert).to eq(['Password : Le mot de passe est vide']) }
       end
     end
   end