feat(routing): reset value if target as changed

app/controllers/administrateurs/routing_controller.rb

@@ -6,13 +6,18 @@ module Administrateurs
 
     def update
       left = targeted_champ
-      right = value
+
+      right = targeted_champ_changed? ? empty : value
 
       groupe_instructeur.update!(routing_rule: ds_eq(left, right))
     end
 
     private
 
+    def targeted_champ_changed?
+      targeted_champ != groupe_instructeur.routing_rule&.left
+    end
+
     def targeted_champ
       Logic.from_json(routing_params[:targeted_champ])
     end

spec/controllers/administrateurs/routing_controller_spec.rb

@@ -3,26 +3,50 @@ describe Administrateurs::RoutingController, type: :controller do
 
   before { sign_in(procedure.administrateurs.first.user) }
 
-  describe '#update' do
+  describe '#update targeted champ' do
-    let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :drop_down_list, libelle: 'Votre ville', options: ['Paris', 'Lyon', 'Marseille'] }]) }
+    let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :drop_down_list, libelle: 'Votre ville', options: ['Paris', 'Lyon', 'Marseille'] }, { type: :text, libelle: 'Un champ texte' }]) }
     let(:gi_2) { procedure.groupe_instructeurs.create(label: 'groupe 2') }
     let(:drop_down_tdc) { procedure.draft_revision.types_de_champ.first }
     let(:params) do
       {
         procedure_id: procedure.id,
-        targeted_champ: drop_down_tdc.stable_id,
+        targeted_champ: champ_value(drop_down_tdc.stable_id).to_json,
-        value: 'Lyon',
+        value: empty.to_json,
         groupe_instructeur_id: gi_2.id
       }
     end
 
     before do
-      sign_in(procedure.administrateurs.first.user)
       post :update, params: params, format: :turbo_stream
     end
 
+    it do
+      expect(gi_2.reload.routing_rule).to eq(ds_eq(champ_value(drop_down_tdc.stable_id), empty))
+    end
+
+    context '#update value' do
+      let(:value_updated_params) { params.merge(value: constant('Lyon').to_json) }
+
+      before do
+        post :update, params: value_updated_params, format: :turbo_stream
+      end
+
       it do
         expect(gi_2.reload.routing_rule).to eq(ds_eq(champ_value(drop_down_tdc.stable_id), constant('Lyon')))
       end
+
+      context 'targeted champ changed' do
+        let(:last_tdc) { procedure.draft_revision.types_de_champ.last }
+
+        before do
+          targeted_champ_updated_params = value_updated_params.merge(targeted_champ: champ_value(last_tdc.stable_id).to_json)
+          post :update, params: targeted_champ_updated_params, format: :turbo_stream
+        end
+
+        it do
+          expect(gi_2.reload.routing_rule).to eq(ds_eq(champ_value(last_tdc.stable_id), empty))
+        end
+      end
+    end
   end
 end