DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feat(Instructeur::ArchivesController#*): prevent SuperAdmin to index/download archives

Browse source
This commit is contained in:
Martin 2022-07-21 15:18:07 +02:00 • committed by mfo
parent c2e0994e11
commit bfd0f3379f
3 changed files with 64 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

59
spec/controllers/instructeurs/archives_controller_spec.rb
View file

@ -1,17 +1,16 @@
describe Instructeurs::ArchivesController, type: :controller do
let(:procedure1) { create(:procedure, :published, groupe_instructeurs: [gi1]) }
let(:procedure1) { create(:procedure, :published, groupe_instructeurs: [assign_to.groupe_instructeur]) }
let(:procedure2) { create(:procedure, :published, groupe_instructeurs: [gi2]) }
let!(:instructeur) { create(:instructeur, groupe_instructeurs: [gi1, gi2]) }
let!(:archive1) { create(:archive, :generated, groupe_instructeurs: [gi1]) }
let!(:instructeur) { create(:instructeur, groupe_instructeurs: [gi2]) }
let!(:archive1) { create(:archive, :generated, groupe_instructeurs: [assign_to.groupe_instructeur]) }
let!(:archive2) { create(:archive, :generated, groupe_instructeurs: [gi2]) }
let(:gi1) { create(:groupe_instructeur) }
let!(:assign_to) { create(:assign_to, instructeur: instructeur, groupe_instructeur: build(:groupe_instructeur), manager: manager) }
let(:gi2) { create(:groupe_instructeur) }
before do
before do
sign_in(instructeur.user)
end
after { Timecop.return }
end
after { Timecop.return }
describe '#index' do
before do
@ -20,25 +19,53 @@ describe Instructeurs::ArchivesController, type: :controller do
create_dossier_for_month(procedure1, 2021, 2)
Timecop.freeze(Time.zone.local(2021, 3, 5))
end
subject{get :index, params: { procedure_id: procedure1.id }}
it 'displays archives' do
get :index, params: { procedure_id: procedure1.id }
context 'signed in not as manager' do
let(:manager){ false }
expect(assigns(:archives)).to eq([archive1])
it { is_expected.to have_http_status(:success) }
it 'assigns archives' do
subject
expect(assigns(:archives)).to eq([archive1])
end
end
context 'signed in as manager' do
let(:manager){ true }
before do
sign_in(instructeur.user)
end
it { is_expected.to have_http_status(:forbidden) }
end
end
describe '#create' do
let(:month) { '21-03' }
let(:date_month) { Date.strptime(month, "%Y-%m") }
let(:subject) do
post :create, params: { procedure_id: procedure1.id, type: 'monthly', month: month }
end
it "performs archive creation job" do
expect { subject }.to have_enqueued_job(ArchiveCreationJob).with(procedure1, an_instance_of(Archive), instructeur)
expect(flash.notice).to include("Votre demande a été prise en compte")
let(:month) { '21-03' }
let(:date_month) { Date.strptime(month, "%Y-%m") }
context 'signed in not as manager' do
let(:manager){ false }
it "performs archive creation job" do
expect { subject }.to have_enqueued_job(ArchiveCreationJob).with(procedure1, an_instance_of(Archive), instructeur)
expect(flash.notice).to include("Votre demande a été prise en compte")
end
end
context 'signed in as manager' do
let(:manager){ true }
it { is_expected.to have_http_status(:forbidden) }
end
end
private