fix heading order by removing useless h4

This commit is contained in:
clemkeirua 2020-07-20 10:03:15 +02:00
parent 0c95e41c6f
commit bc34905742
3 changed files with 6 additions and 6 deletions

View file

@ -3,7 +3,7 @@
= form.label champ.main_value_name do = form.label champ.main_value_name do
= render partial: 'shared/dossiers/editable_champs/champ_label_content', locals: { champ: champ, seen_at: seen_at } = render partial: 'shared/dossiers/editable_champs/champ_label_content', locals: { champ: champ, seen_at: seen_at }
- else - else
%h4.form-label .form-label.mb-4
= render partial: 'shared/dossiers/editable_champs/champ_label_content', locals: { champ: champ, seen_at: seen_at } = render partial: 'shared/dossiers/editable_champs/champ_label_content', locals: { champ: champ, seen_at: seen_at }
- if champ.description.present? - if champ.description.present?

View file

@ -62,7 +62,7 @@ feature 'wcag rules for usager', js: true do
fill_in('individual_nom', with: 'nom') fill_in('individual_nom', with: 'nom')
click_on 'Continuer' click_on 'Continuer'
expect(page).to be_accessible.skipping :'aria-input-field-name', :'heading-order', :label expect(page).to be_accessible.skipping :'aria-input-field-name', :label
end end
end end
@ -93,7 +93,7 @@ feature 'wcag rules for usager', js: true do
scenario 'dossier' do scenario 'dossier' do
visit dossier_path(dossier) visit dossier_path(dossier)
expect(page).to be_accessible.skipping :'heading-order', :label, :'aria-input-field-name' expect(page).to be_accessible.skipping :label, :'aria-input-field-name'
end end
scenario 'merci' do scenario 'merci' do
@ -113,12 +113,12 @@ feature 'wcag rules for usager', js: true do
scenario 'modifier' do scenario 'modifier' do
visit modifier_dossier_path(dossier) visit modifier_dossier_path(dossier)
expect(page).to be_accessible.skipping :'aria-input-field-name', :'heading-order', :label expect(page).to be_accessible.skipping :'aria-input-field-name', :label
end end
scenario 'brouillon' do scenario 'brouillon' do
visit brouillon_dossier_path(dossier) visit brouillon_dossier_path(dossier)
expect(page).to be_accessible.skipping :'aria-input-field-name', :'heading-order', :label expect(page).to be_accessible.skipping :'aria-input-field-name', :label
end end
end end
end end

View file

@ -325,7 +325,7 @@ feature 'The user' do
# </select> # </select>
# <!-- … 4 other selects for month, year, minute and seconds --> # <!-- … 4 other selects for month, year, minute and seconds -->
# </div> # </div>
e = find(:xpath, ".//h4[contains(text()[normalize-space()], '#{libelle}')]") e = find(:xpath, ".//div[contains(text()[normalize-space()], '#{libelle}')]")
e.sibling('.datetime').first('select')[:id][0..-4] e.sibling('.datetime').first('select')[:id][0..-4]
end end