DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

controllers: disable explicit purge of invalid file

Browse source
This commit is contained in:
Pierre de La Morinerie 2020-06-24 17:25:32 +02:00
parent 719915e69f
commit b8706757e3
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/controllers/champs/piece_justificative_controller.rb
View file

@ -9,12 +9,6 @@ class Champs::PieceJustificativeController < ApplicationController
render :show render :show
else else
errors = @champ.errors.full_messages errors = @champ.errors.full_messages
# Before Rails 6, the attachment was persisted to database
# by 'attach', even before calling save.
# So until we're on Rails 6, we need to purge the file explicitely.
@champ.piece_justificative_file.purge_later
render :json => { errors: errors }, :status => 422 render :json => { errors: errors }, :status => 422
end end
end end

2
spec/controllers/champs/piece_justificative_controller_spec.rb
View file

@ -44,7 +44,7 @@ describe Champs::PieceJustificativeController, type: :controller do
# See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926 # See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926
before do before do
champ champ
expect_any_instance_of(Champs::PieceJustificativeChamp).to receive(:save).and_return(false) expect_any_instance_of(Champs::PieceJustificativeChamp).to receive(:save).twice.and_return(false)
expect_any_instance_of(Champs::PieceJustificativeChamp).to receive(:errors) expect_any_instance_of(Champs::PieceJustificativeChamp).to receive(:errors)
.and_return(double(full_messages: ['La pièce justificative n’est pas d’un type accepté'])) .and_return(double(full_messages: ['La pièce justificative n’est pas d’un type accepté']))
end end