Merge pull request #6083 from betagouv/fix_missing_dossier_for_avis
ne demande pas un avis si le dossier a été supprimé
This commit is contained in:
commit
b294566f2a
2 changed files with 15 additions and 5 deletions
|
@ -5,6 +5,7 @@ class AvisMailer < ApplicationMailer
|
|||
layout 'mailers/layout'
|
||||
|
||||
def avis_invitation(avis)
|
||||
if avis.dossier.present?
|
||||
@avis = avis
|
||||
email = @avis.expert&.email
|
||||
subject = "Donnez votre avis sur le dossier nº #{@avis.dossier.id} (#{@avis.dossier.procedure.libelle})"
|
||||
|
@ -12,3 +13,4 @@ class AvisMailer < ApplicationMailer
|
|||
mail(to: email, subject: subject)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -6,7 +6,7 @@ RSpec.describe AvisMailer, type: :mailer do
|
|||
let(:experts_procedure) { create(:experts_procedure, expert: expert, procedure: dossier.procedure) }
|
||||
let(:avis) { create(:avis, dossier: dossier, claimant: claimant, experts_procedure: experts_procedure, introduction: 'intro') }
|
||||
|
||||
subject { described_class.avis_invitation(avis) }
|
||||
subject { described_class.avis_invitation(avis.reload) }
|
||||
|
||||
it { expect(subject.subject).to eq("Donnez votre avis sur le dossier nº #{avis.dossier.id} (#{avis.dossier.procedure.libelle})") }
|
||||
it { expect(subject.body).to have_text("Vous avez été invité par\r\n#{avis.claimant.email}\r\nà donner votre avis sur le dossier nº #{avis.dossier.id} de la démarche :\r\n#{avis.dossier.procedure.libelle}") }
|
||||
|
@ -16,5 +16,13 @@ RSpec.describe AvisMailer, type: :mailer do
|
|||
context 'when the recipient is not already registered' do
|
||||
it { expect(subject.body).to include(sign_up_expert_avis_url(avis.dossier.procedure.id, avis.id, avis.expert.email)) }
|
||||
end
|
||||
|
||||
context 'when the dossier has been deleted before the avis was sent' do
|
||||
before { dossier.update(hidden_at: Time.zone.now) }
|
||||
|
||||
it 'doesn’t send the email' do
|
||||
expect(subject.body).to be_blank
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue