DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge #5316

Browse source 
5316: fix missing aria-labels in footer r=Keirua a=Keirua

début du cleanup des exclusions d'accessibilité
(et bon candidat pour tester si bors fonctionne comme prévu)

Co-authored-by: clemkeirua <clement@keiruaprod.fr>
This commit is contained in:
bors[bot] 2020-07-01 09:28:02 +00:00 committed by GitHub
commit b135b5cfb0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/root/_footer.html.haml
View file

@ -12,9 +12,9 @@
= link_to "beta.gouv.fr", "https://beta.gouv.fr", title: "le site de Beta.gouv.fr" = link_to "beta.gouv.fr", "https://beta.gouv.fr", title: "le site de Beta.gouv.fr"
%li %li
= link_to "https://numerique.gouv.fr/", title: "DINUM", 'aria-label': 'DINUM' do = link_to "https://numerique.gouv.fr/", title: "DINUM", 'aria-label': 'DINUM' do
%span.footer-logo.footer-logo-dinum{ role: 'img' } %span.footer-logo.footer-logo-dinum{ role: 'img', 'aria-label': 'Logo DINUM' }
= link_to "https://beta.gouv.fr", title: "le site de Beta.gouv.fr", 'aria-label': 'beta.gouv.fr' do = link_to "https://beta.gouv.fr", title: "le site de Beta.gouv.fr", 'aria-label': 'beta.gouv.fr' do
%span.footer-logo.footer-logo-beta-gouv-fr{ role: 'img' } %span.footer-logo.footer-logo-beta-gouv-fr{ role: 'img', 'aria-label': 'Logo beta.gouv.fr' }
%span.footer-logo.footer-logo-france{ role: 'img', 'aria-label': 'République Française' } %span.footer-logo.footer-logo-france{ role: 'img', 'aria-label': 'République Française' }
%li.footer-column %li.footer-column

8
spec/features/accessibilite/wcag_usager_spec.rb
View file

@ -6,12 +6,12 @@ feature 'wcag rules for usager', js: true do
context 'pages without the need to be logged in' do context 'pages without the need to be logged in' do
scenario 'homepage' do scenario 'homepage' do
visit root_path visit root_path
expect(page).to be_accessible.excluding ".footer-logo" expect(page).to be_accessible
end end
scenario 'sign_up page' do scenario 'sign_up page' do
visit new_user_registration_path visit new_user_registration_path
expect(page).to be_accessible.excluding ".footer-logo" expect(page).to be_accessible
end end
scenario 'account confirmation page' do scenario 'account confirmation page' do
@ -28,12 +28,12 @@ feature 'wcag rules for usager', js: true do
scenario 'sign_in page' do scenario 'sign_in page' do
visit new_user_session_path visit new_user_session_path
expect(page).to be_accessible.excluding ".footer-logo", '#user_email' expect(page).to be_accessible.excluding '#user_email'
end end
scenario 'contact page' do scenario 'contact page' do
visit contact_path visit contact_path
expect(page).to be_accessible.excluding ".footer-logo" expect(page).to be_accessible
end end
scenario 'commencer page' do scenario 'commencer page' do