DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feat(remove_type_de_champ): stop renumbering all procedure_revision_type_de_champ on remove_type_de_champ

Browse source
This commit is contained in:
Martin 2024-01-17 16:01:30 +01:00 committed by mfo
parent 4d97c5bc8a
commit a78a6b6f34
1 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
app/models/procedure_revision.rb
View file

@ -101,18 +101,6 @@ class ProcedureRevision < ApplicationRecord
coordinate
end
def incr_coordinates_above(siblings, position)
siblings.where("position >= ?", position).update_all("position = position + 1")
end
def decr_siblings_between(coordinate, position)
coordinate.siblings.where(position: coordinate.position..position).update_all("position = position - 1")
end
def inc_siblings_between(coordinate, position)
coordinate.siblings.where(position: position..coordinate.position).update_all("position = position + 1")
end
def remove_type_de_champ(stable_id)
coordinate, tdc = coordinate_and_tdc(stable_id)
@ -129,7 +117,7 @@ class ProcedureRevision < ApplicationRecord
types_de_champ_public.reset
types_de_champ_private.reset
renumber(coordinate.siblings)
decr_siblings_above(coordinate.siblings, coordinate.position)
coordinate
end
@ -276,12 +264,24 @@ class ProcedureRevision < ApplicationRecord
end
end
def renumber(siblings)
siblings.to_a.compact.each.with_index do |sibling, position|
sibling.update_column(:position, position)
def incr_coordinates_above(siblings, position)
siblings.where("position >= ?", position).update_all("position = position + 1")
end
def decr_siblings_above(coordinate)
coordinate.siblings.where("position >= ?", coordinate.position).update_all("position = position - 1")
end
def decr_siblings_between(coordinate, position)
coordinate.siblings.where(position: coordinate.position..position).update_all("position = position - 1")
end
def inc_siblings_between(coordinate, position)
coordinate.siblings.where(position: position..coordinate.position).update_all("position = position + 1")
end
def compare_revision_types_de_champ(from_coordinates, to_coordinates)
if from_coordinates == to_coordinates
[]