DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #6010 from betagouv/fix-missing-attestation-message

Browse source 
Instructeur : correction du message d'avertissement lorsqu'un champ d'attestation est manquant (#6010)
This commit is contained in:
Pierre de La Morinerie 2021-03-23 17:02:44 +01:00 committed by GitHub
commit a580b7daf9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/instructeurs/dossiers/_state_button_motivation.html.haml
View file

@ -16,7 +16,7 @@
- if unspecified_attestation_champs.present?
.warning
Attention, les valeurs suivantes n'ont pas été renseignées mais sont nécessaires pour pouvoir envoyer une attestation valide :
- unspecified_champs, unspecified_annotations_privees = unspecified_attestation_champs.partition(&:private)
- unspecified_annotations_privees, unspecified_champs = unspecified_attestation_champs.partition(&:private)
- if unspecified_champs.present?
%h4 Champs de la demande

15
spec/views/instructeur/dossiers/_state_button_motivation.html.haml_spec.rb
View file

@ -1,7 +1,7 @@
describe 'instructeurs/dossiers/state_button_motivation.html.haml', type: :view do
let(:dossier) { create(:dossier, :en_instruction) }
subject! do
subject do
render(
'instructeurs/dossiers/state_button_motivation.html.haml',
dossier: dossier,
@ -14,12 +14,15 @@ describe 'instructeurs/dossiers/state_button_motivation.html.haml', type: :view
)
end
context 'with an attestation preview' do
let(:dossier) { create :dossier, :accepte, :with_attestation }
it { expect(rendered).to have_link(href: apercu_attestation_instructeur_dossier_path(dossier.procedure, dossier)) }
context 'without attestation' do
it { expect(subject).not_to have_link(href: apercu_attestation_instructeur_dossier_path(dossier.procedure, dossier)) }
end
context 'without an attestation preview' do
it { expect(rendered).not_to have_link(href: apercu_attestation_instructeur_dossier_path(dossier.procedure, dossier)) }
context 'with an attestation' do
let(:dossier) { create :dossier, :accepte, :with_attestation }
it 'includes a link to preview the attestation' do
expect(subject).to have_link(href: apercu_attestation_instructeur_dossier_path(dossier.procedure, dossier))
end
end
end