DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #10098 from colinux/dont-report-every-invalid-auth-token

Browse source 
Tech: ne remonte plus que 10% des InvalidAuthenticityToken errors
This commit is contained in:
mfo 2024-03-12 09:04:57 +00:00 • committed by GitHub
commit a106394e89
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/controllers/application_controller/error_handling.rb
View file

@ -5,10 +5,12 @@ module ApplicationController::ErrorHandling
rescue_from ActionController::InvalidAuthenticityToken do rescue_from ActionController::InvalidAuthenticityToken do
# When some browsers (like Safari) re-open a previously closed tab, they attempts # When some browsers (like Safari) re-open a previously closed tab, they attempts
# to reload the page – even if it is a POST request. But in that case, they don’t # to reload the page – even if it is a POST request. But in that case, they don’t
# sends any of the cookies. # sends any of the cookies and we don’t report this error.
# #
# In that case, don’t report this error. # There are dozens of these "errors" every day,
if request.cookies.count > 0 # we only log them to detect massive attacks or global errors
# without having thousands reports.
if request.cookies.any? && rand(10) == 0
log_invalid_authenticity_token_error log_invalid_authenticity_token_error
end end

5
spec/controllers/application_controller/error_handling_spec.rb
View file

@ -16,7 +16,10 @@ RSpec.describe ApplicationController::ErrorHandling, type: :controller do
{ 'some_cookie': true } { 'some_cookie': true }
end end
before { cookies.update(request_cookies) } before do
cookies.update(request_cookies)
allow(controller).to receive(:rand).and_return(0)
end
it 'logs the error' do it 'logs the error' do
allow(Sentry).to receive(:capture_message) allow(Sentry).to receive(:capture_message)