DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #3620 from betagouv/fix-3617

Browse source 
[Fix #3617] 404 when filter[value] contains a "."
This commit is contained in:
Mathieu Magnin 2019-03-19 14:31:45 +01:00 • committed by GitHub
commit 9d40ad614e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/new_gestionnaire/procedures/show.html.haml
View file

@ -66,7 +66,7 @@
- if i > 0 - if i > 0
ou ou
%span.filter %span.filter
= link_to remove_filter_gestionnaire_procedure_path(@procedure, statut: @statut, table: filter['table'], column: filter['column'], value: filter['value']) do = link_to remove_filter_gestionnaire_procedure_path(@procedure, { statut: @statut, table: filter['table'], column: filter['column'], value: filter['value'] }) do
%img.close-icon{ src: image_url("close.svg") } %img.close-icon{ src: image_url("close.svg") }
= "#{filter['label'].truncate(50)} : #{filter['value']}" = "#{filter['label'].truncate(50)} : #{filter['value']}"
%table.table.dossiers-table.hoverable %table.table.dossiers-table.hoverable

2
config/routes.rb
View file

@ -313,7 +313,7 @@ Rails.application.routes.draw do
patch 'update_displayed_fields' patch 'update_displayed_fields'
get 'update_sort/:table/:column' => 'procedures#update_sort', as: 'update_sort' get 'update_sort/:table/:column' => 'procedures#update_sort', as: 'update_sort'
post 'add_filter' post 'add_filter'
get 'remove_filter/:statut/:table/:column/:value' => 'procedures#remove_filter', as: 'remove_filter' get 'remove_filter' => 'procedures#remove_filter', as: 'remove_filter'
get 'download_dossiers' get 'download_dossiers'
get 'email_notifications' get 'email_notifications'
patch 'update_email_notifications' patch 'update_email_notifications'

2
spec/features/new_gestionnaire/procedure_filters_spec.rb
View file

@ -115,7 +115,7 @@ feature "procedure filters" do
end end
def remove_filter(filter_value) def remove_filter(filter_value)
find(:xpath, "(//span[contains(@class, 'filter')]/a[contains(@href, '#{URI.encode(filter_value)}')])[1]").click find(:xpath, "(//span[contains(@class, 'filter')]/a[contains(@href, '#{CGI.escape(filter_value)}')])[1]").click
end end
def add_filter(column_name, filter_value) def add_filter(column_name, filter_value)