batch it

app/lib/active_storage/downloadable_file.rb

@@ -1,8 +1,7 @@
 class ActiveStorage::DownloadableFile
   def self.create_list_from_dossiers(dossiers, for_expert = false)
-    dossiers
+    PiecesJustificativesService.generate_dossier_export(dossiers) +
-      .map { |d| pj_and_path(d.id, PiecesJustificativesService.generate_dossier_export(d)) } +
+      PiecesJustificativesService.liste_documents(dossiers, for_expert)
-    PiecesJustificativesService.liste_documents(dossiers, for_expert)
   end
 
   private

app/services/pieces_justificatives_service.rb

@@ -107,21 +107,29 @@ class PiecesJustificativesService
     end
   end
 
-  def self.generate_dossier_export(dossier)
+  def self.generate_dossier_export(dossiers)
-    pdf = ApplicationController
+    pdfs = []
-      .render(template: 'dossiers/show', formats: [:pdf],
-              assigns: {
-                include_infos_administration: true,
-                dossier: dossier
-              })
 
-    FakeAttachment.new(
+    dossiers.find_each do |dossier|
-      file: StringIO.new(pdf),
+      pdf = ApplicationController
-      filename: "export-#{dossier.id}.pdf",
+        .render(template: 'dossiers/show', formats: [:pdf],
-      name: 'pdf_export_for_instructeur',
+                assigns: {
-      id: dossier.id,
+                  include_infos_administration: true,
-      created_at: dossier.updated_at
+                  dossier: dossier
-    )
+                })
+
+      a = FakeAttachment.new(
+        file: StringIO.new(pdf),
+        filename: "export-#{dossier.id}.pdf",
+        name: 'pdf_export_for_instructeur',
+        id: dossier.id,
+        created_at: dossier.updated_at
+      )
+
+      pdfs << ActiveStorage::DownloadableFile.pj_and_path(dossier.id, a)
+    end
+
+    pdfs
   end
 
   private

spec/services/pieces_justificatives_service_spec.rb

@@ -192,7 +192,7 @@ describe PiecesJustificativesService do
   describe '.generate_dossier_export' do
     let(:dossier) { create(:dossier) }
 
-    subject { PiecesJustificativesService.generate_dossier_export(dossier) }
+    subject { PiecesJustificativesService.generate_dossier_export(Dossier.where(id: dossier.id)) }
 
     it "doesn't update dossier" do
       expect { subject }.not_to change { dossier.updated_at }

spec/services/procedure_export_service_spec.rb

@@ -437,6 +437,7 @@ describe ProcedureExportService do
 
     context 'with files (and http calls)' do
       let!(:dossier) { create(:dossier, :accepte, :with_populated_champs, :with_individual, procedure: procedure) }
+      let(:dossier_exports) { PiecesJustificativesService.generate_dossier_export(Dossier.where(id: dossier)) }
 
       before do
         allow_any_instance_of(ActiveStorage::Attachment).to receive(:url).and_return("https://opengraph.githubassets.com/d0e7862b24d8026a3c03516d865b28151eb3859029c6c6c2e86605891fbdcd7a/socketry/async-io")
@@ -454,7 +455,7 @@ describe ProcedureExportService do
               "#{service.send(:base_filename)}/dossier-#{dossier.id}/",
               "#{service.send(:base_filename)}/dossier-#{dossier.id}/pieces_justificatives/",
               "#{service.send(:base_filename)}/dossier-#{dossier.id}/#{ActiveStorage::DownloadableFile.timestamped_filename(ActiveStorage::Attachment.where(record_type: "Champ").first)}",
-              "#{service.send(:base_filename)}/dossier-#{dossier.id}/#{ActiveStorage::DownloadableFile.timestamped_filename(PiecesJustificativesService.generate_dossier_export(dossier))}"
+              "#{service.send(:base_filename)}/dossier-#{dossier.id}/#{ActiveStorage::DownloadableFile.timestamped_filename(dossier_exports.first.first)}"
             ]
             expect(files.size).to eq(structure.size)
             expect(files.map(&:filename)).to match_array(structure)