Merge pull request #10660 from colinux/fix-attestation-draft

ETQ admin sur une démarche en brouillon, l'attestation v2 est créé en brouillon si on a déjà une v1 active
This commit is contained in:
Paul Chavard 2024-07-30 08:12:55 +00:00 committed by GitHub
commit 9aa86031cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 19 additions and 2 deletions

View file

@ -133,7 +133,13 @@ module Administrateurs
@procedure.attestation_templates.build(version: 2, json_body: AttestationTemplate::TIPTAP_BODY_DEFAULT, activated: true, state:) @procedure.attestation_templates.build(version: 2, json_body: AttestationTemplate::TIPTAP_BODY_DEFAULT, activated: true, state:)
end end
def should_edit_draft? = !@procedure.brouillon? def should_edit_draft?
if @procedure.brouillon?
@procedure.attestation_templates.v1.published.any?
else
true
end
end
def editor_params def editor_params
params.required(:attestation_template).permit(:activated, :official_layout, :label_logo, :label_direction, :tiptap_body, :footer, :logo, :signature, :activated, :state) params.required(:attestation_template).permit(:activated, :official_layout, :label_logo, :label_direction, :tiptap_body, :footer, :logo, :signature, :activated, :state)

View file

@ -20,7 +20,7 @@
tout en respectant la charte de létat. Essayez-la et donnez-nous votre avis tout en respectant la charte de létat. Essayez-la et donnez-nous votre avis
en nous envoyant un email à #{mail_to(Current.contact_email, subject: "Feedback attestation v2")}. en nous envoyant un email à #{mail_to(Current.contact_email, subject: "Feedback attestation v2")}.
%br %br
- if !@procedure.feature_enabled?(:attestation_v2) - if !@procedure.feature_enabled?(:attestation_v2) || @procedure.attestation_templates.v1.published.any?
%strong Les attestations délivrées suivent encore lancien format : %strong Les attestations délivrées suivent encore lancien format :
lactivation des attestations basées sur ce format sera bientôt disponible. lactivation des attestations basées sur ce format sera bientôt disponible.
%br %br

View file

@ -142,6 +142,17 @@ describe Administrateurs::AttestationTemplateV2sController, type: :controller do
expect(assigns(:attestation_template)).to be_draft expect(assigns(:attestation_template)).to be_draft
expect(attestation_template.reload).to be_present expect(attestation_template.reload).to be_present
end end
context 'on a draft procedure' do
let(:procedure) { create(:procedure, :draft, administrateur: admin, attestation_template:, libelle: "Ma démarche") }
it 'build v2 as draft' do
subject
expect(assigns(:attestation_template).version).to eq(2)
expect(assigns(:attestation_template)).to be_draft
expect(attestation_template.reload).to be_present
end
end
end end
context 'attestation template published exist without draft' do context 'attestation template published exist without draft' do