DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feat(champ siret): improve default base SIRET column wording

Browse source
This commit is contained in:
Colin Darie 2024-11-20 16:36:25 +01:00
parent b71d60dff9
commit 985cf32752
No known key found for this signature in database
GPG key ID: 4FB865FDBCA4BCC4
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/models/types_de_champ/type_de_champ_base.rb
View file

@ -116,8 +116,13 @@ class TypesDeChamp::TypeDeChampBase
private private
def libelle_with_prefix(prefix) def libelle_with_prefix(prefix)
# SIRET needs to be explicit in listings for better UI readability
if type_champ == "siret" && !libelle.upcase.include?("SIRET")
[prefix, libelle, "SIRET"].compact.join(' – ')
else
[prefix, libelle].compact.join(' – ') [prefix, libelle].compact.join(' – ')
end end
end
def paths def paths
[ [

10
spec/models/types_de_champ/siret_type_de_champ_spec.rb
View file

@ -7,6 +7,16 @@ describe TypesDeChamp::SiretTypeDeChamp do
describe "#columns" do describe "#columns" do
subject(:columns) { tdc_siret.columns(procedure: procedure) } subject(:columns) { tdc_siret.columns(procedure: procedure) }
it "returns base column without duplicating SIRET when already in libelle" do
expect(columns[0].label).to eq("Numéro SIRET")
end
it "returns base column with SIRET when libelle doesn't contain SIRET" do
tdc_siret.update(libelle: "Identification de l'entreprise")
expect(columns[0].label).to eq("Identification de l'entreprise – SIRET")
end
it "includes required jsonpaths" do it "includes required jsonpaths" do
expected_paths = [ expected_paths = [
"$.entreprise_raison_sociale", "$.entreprise_raison_sociale",