feat(stats#index): update Stat model to also query DossierDeleted in stats computation

tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?

feat(stats): add DeletedDossier in Stat computations

Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?"

This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089.

feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos

clean(rubocop): lint with rubocop

Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb

Co-authored-by: LeSim <mail@simon.lehericey.net>

fix(rubocop): avoid uneeded allocation

fix(migration): add concurrent index with expected synthax

fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself

spec/models/stat_spec.rb

@@ -0,0 +1,102 @@
+describe Stat do
+  describe '.deleted_dossiers_states' do
+    subject { Stat.send(:deleted_dossiers_states) }
+    it 'find counts for columns' do
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :termine)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :en_construction, deleted_at: 1.month.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :en_construction, deleted_at: 2.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :brouillon, deleted_at: 3.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :en_construction, deleted_at: 3.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :en_instruction, deleted_at: 3.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :accepte, deleted_at: 3.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :refuse, deleted_at: 3.months.ago)
+      create(:deleted_dossier, dossier_id: create(:dossier).id, state: :sans_suite, deleted_at: 3.months.ago)
+
+      expect(subject["not_brouillon"]).to eq(8)
+      expect(subject["dossiers_depose_avant_30_jours"]).to eq(1)
+      expect(subject["dossiers_deposes_entre_60_et_30_jours"]).to eq(1)
+      expect(subject["brouillon"]).to eq(1)
+      expect(subject["en_construction"]).to eq(3)
+      expect(subject["en_instruction"]).to eq(1)
+      expect(subject["termines"]).to eq(3)
+    end
+  end
+
+  describe '.update_stats' do
+    it 'merges dossiers_states and deleted_dossiers_states' do
+      stats = {
+        "not_brouillon" => 1,
+        "dossiers_depose_avant_30_jours" => 2,
+        "dossiers_deposes_entre_60_et_30_jours" => 3,
+        "brouillon" => 4,
+        "en_construction" => 5,
+        "en_instruction" => 6,
+        "termines" => 7
+      }
+      allow(Stat).to receive(:dossiers_states).and_return(stats)
+      allow(Stat).to receive(:deleted_dossiers_states).and_return(stats)
+
+      Stat.update_stats
+      computed_stats = Stat.first
+
+      expect(computed_stats.dossiers_not_brouillon).to eq(stats["not_brouillon"] * 2)
+      expect(computed_stats.dossiers_depose_avant_30_jours).to eq(stats["dossiers_depose_avant_30_jours"] * 2)
+      expect(computed_stats.dossiers_deposes_entre_60_et_30_jours).to eq(stats["dossiers_deposes_entre_60_et_30_jours"] * 2)
+      expect(computed_stats.dossiers_brouillon).to eq(stats["brouillon"] * 2)
+      expect(computed_stats.dossiers_en_construction).to eq(stats["en_construction"] * 2)
+      expect(computed_stats.dossiers_en_instruction).to eq(stats["en_instruction"] * 2)
+      expect(computed_stats.dossiers_termines).to eq(stats["termines"] * 2)
+    end
+  end
+
+  describe '.cumulative_hash' do
+    it 'works count and cumulate counters by month for both dossier and deleted dossiers' do
+      12.downto(1).map do |i|
+        create(:dossier, state: :en_construction, en_construction_at: i.months.ago)
+        create(:deleted_dossier, dossier_id: i + 100, state: :en_construction, deleted_at: i.month.ago)
+      end
+      rs = Stat.send(:cumulative_hash, [
+        [Dossier.state_not_brouillon, :en_construction_at],
+        [DeletedDossier.where.not(state: :brouillon), :deleted_at]
+      ])
+      expect(rs).to eq({
+        12.months.ago.utc.beginning_of_month => 2,
+       11.months.ago.utc.beginning_of_month => 4,
+       10.months.ago.utc.beginning_of_month => 6,
+       9.months.ago.utc.beginning_of_month => 8,
+       8.months.ago.utc.beginning_of_month => 10,
+       7.months.ago.utc.beginning_of_month => 12,
+       6.months.ago.utc.beginning_of_month => 14,
+       5.months.ago.utc.beginning_of_month => 16,
+       4.months.ago.utc.beginning_of_month => 18,
+       3.months.ago.utc.beginning_of_month => 20,
+       2.months.ago.utc.beginning_of_month => 22,
+       1.month.ago.utc.beginning_of_month => 24
+      })
+    end
+  end
+
+  describe '.last_four_months_hash' do
+    it 'works count and cumulate counters by month for both dossier and deleted dossiers' do
+      4.downto(1).map do |i|
+        create(:dossier, state: :en_construction, en_construction_at: i.months.ago)
+        create(:deleted_dossier, dossier_id: i + 100, state: :en_construction, deleted_at: i.month.ago)
+      end
+      rs = Stat.send(:last_four_months_hash, [
+        [Dossier.state_not_brouillon, :en_construction_at],
+        [DeletedDossier.where.not(state: :brouillon), :deleted_at]
+      ])
+      expect(rs).to eq([
+        ["août 2021", 2],
+        ["septembre 2021", 2],
+        ["octobre 2021", 2]
+      ])
+    end
+  end
+
+  describe '.sum_hashes' do
+    it 'sum up hashes keys' do
+      expect(Stat.send(:sum_hashes, *[{ a: 1, b: 2, d: 5 }, { a: 2, b: 3, c: 5 }])).to eq({ a: 3, b: 5, c: 5, d: 5 })
+    end
+  end
+end