DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Further refactor SiretFormatValidator#validate_each

Browse source
This commit is contained in:
gregoirenovel 2018-09-19 10:28:07 +02:00
parent 36950b985b
commit 940dfe422b
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/validators/siret_format_validator.rb
View file

@ -1,16 +1,24 @@
class SiretFormatValidator < ActiveModel::EachValidator class SiretFormatValidator < ActiveModel::EachValidator
def validate_each(record, attribute, value) def validate_each(record, attribute, value)
if !value&.match?(/^\d{14}$/) if !format_is_valid(value)
record.errors.add(attribute, :format) record.errors.add(attribute, :format)
end end
if value.present? && (luhn_checksum(value) % 10 != 0) if !luhn_passed(value)
record.errors.add(attribute, :checksum) record.errors.add(attribute, :checksum)
end end
end end
private private
def format_is_valid(value)
value&.match?(/^\d{14}$/)
end
def luhn_passed(value)
value.present? && (luhn_checksum(value) % 10 == 0)
end
def luhn_checksum(value) def luhn_checksum(value)
accum = 0 accum = 0