DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

bug(validation-des-conditions): les conditions dans un bloc repetable ne remontent pas dans la liste des erreurs de la page formulaire ou sur les changements du formulaire

Browse source
This commit is contained in:
Martin 2023-03-31 10:27:53 +02:00
parent 5dd6456e4a
commit 92f5e7663e
1 changed files with 25 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
spec/models/procedure_revision_spec.rb
View file

@ -828,21 +828,22 @@ describe ProcedureRevision do
draft_revision.errors
end
before { second_champ.update(condition: condition) }
context 'when a champ has a valid condition (type)' do
before { second_champ.update(condition: condition) }
let(:condition) { ds_eq(constant(true), constant(true)) }
it { is_expected.to be_empty }
end
context 'when a champ has a valid condition: needed tdc is up in the forms' do
before { second_champ.update(condition: condition) }
let(:condition) { ds_eq(champ_value(first_champ.stable_id), constant(1)) }
it { is_expected.to be_empty }
end
context 'when a champ has an invalid condition' do
before { second_champ.update(condition: condition) }
let(:condition) { ds_eq(constant(true), constant(1)) }
it { expect(subject.first.attribute).to eq(:condition) }
@ -851,7 +852,28 @@ describe ProcedureRevision do
context 'when a champ has an invalid condition: needed tdc is down in the forms' do
let(:need_second_champ) { ds_eq(constant('oui'), champ_value(second_champ.stable_id)) }
before { first_champ.update(condition: need_second_champ) }
before do
second_champ.update(condition: condition)
first_champ.update(condition: need_second_champ)
end
it { expect(subject.first.attribute).to eq(:condition) }
end
context 'when a champ belongs to a repetition' do
let(:procedure) do
create(:procedure,
types_de_champ_public: [{ type: :repetition, children: [{ type: :integer_number }, { type: :text }] }])
end
let(:condition) { ds_eq(constant(true), constant(1)) }
before do
repetition = procedure.draft_revision.types_de_champ_public.find(&:repetition?)
champs_repetition = procedure.draft_revision.children_of(repetition)
integer_champ = champs_repetition.first
text_champ = champs_repetition.last
text_champ.update(condition: condition)
end
it { expect(subject.first.attribute).to eq(:condition) }
end