Merge pull request #5161 from betagouv/remove-auto-upload-feature-flag

app: remove the feature flag for pieces justificatives auto-upload

app/helpers/champ_helper.rb

@@ -33,7 +33,7 @@ module ChampHelper
   end
 
   def auto_attach_url(form, object)
-    if feature_enabled?(:autoupload_dossier_attachments) && object.is_a?(Champ) && object.persisted? && object.public?
+    if object.is_a?(Champ) && object.persisted? && object.public?
       champs_piece_justificative_url(object.id)
     end
   end

config/initializers/flipper.rb

@@ -31,7 +31,6 @@ features = [
   :insee_api_v3,
   :instructeur_bypass_email_login_token,
   :autosave_dossier_draft,
-  :autoupload_dossier_attachments,
   :new_map_editor,
   :maintenance_mode,
   :mini_profiler,

spec/features/users/brouillon_spec.rb

@@ -165,42 +165,6 @@ feature 'The user' do
     create(:procedure, :published, :for_individual, types_de_champ: tdcs)
   end
 
-  scenario 'adding, replacing and removing attachments', js: true do
-    log_in(user, procedure_with_pj)
-    fill_individual
-
-    # Add an attachment
-    find_field('Pièce justificative').attach_file(Rails.root + 'spec/fixtures/files/file.pdf')
-    click_on 'Enregistrer le brouillon'
-    expect(page).to have_content('Votre brouillon a bien été sauvegardé')
-    expect(page).to have_text('file.pdf')
-    expect(page).to have_text('analyse antivirus en cours')
-
-    # Mark file as scanned and clean
-    attachment = ActiveStorage::Attachment.last
-    attachment.blob.update(metadata: attachment.blob.metadata.merge(scanned_at: Time.zone.now, virus_scan_result: ActiveStorage::VirusScanner::SAFE))
-    within('.attachment') { click_on 'rafraichir' }
-    expect(page).to have_link('file.pdf')
-    expect(page).to have_no_content('analyse antivirus en cours')
-
-    # Replace the attachment
-    within('.attachment') { click_on 'Remplacer' }
-    find_field('Pièce justificative').attach_file(Rails.root + 'spec/fixtures/files/RIB.pdf')
-    click_on 'Enregistrer le brouillon'
-    expect(page).to have_no_text('file.pdf')
-    expect(page).to have_text('RIB.pdf')
-
-    # Remove the attachment
-    within('.attachment') { click_on 'Supprimer' }
-    expect(page).to have_content('La pièce jointe a bien été supprimée')
-    expect(page).to have_no_text('RIB.pdf')
-  end
-
-  context 'when the auto-uploads of attachments is enabled' do
-    before do
-      Flipper.enable_actor(:autoupload_dossier_attachments, user)
-    end
-
   scenario 'add an attachment', js: true do
     log_in(user, procedure_with_pjs)
     fill_individual
@@ -273,7 +237,6 @@ feature 'The user' do
     # Expect the file to have been saved on the dossier
     expect(page).to have_text('file.pdf')
   end
-  end
 
   context 'when the draft autosave is enabled' do
     before do