DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #8729 from colinux/fix-groupe-instructeur-wrongly-invalid

Browse source 
fix(groupe-instructeur): un groupe instructeur inactif est valide tant qu'il reste un groupe actif
This commit is contained in:
Colin Darie 2023-03-06 10:13:16 +00:00 committed by GitHub
commit 8722ee028d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/groupe_instructeur.rb
View file

@ -22,7 +22,7 @@ class GroupeInstructeur < ApplicationRecord
validates :label, presence: true, allow_nil: false
validates :label, uniqueness: { scope: :procedure }
validates :closed, acceptance: { accept: [false] }, if: -> { self.procedure.groupe_instructeurs.active.one? }
validates :closed, acceptance: { accept: [false] }, if: -> { closed_changed? && self.procedure.groupe_instructeurs.active.one? }
before_validation -> { label&.strip! }
after_save :toggle_routing

18
spec/models/groupe_instructeur_spec.rb
View file

@ -98,6 +98,24 @@ describe GroupeInstructeur, type: :model do
end
end
describe "active group validations" do
context "there is at least one active groupe instructeur" do
let!(:gi_active) { create(:groupe_instructeur, procedure:, closed: false) }
let!(:gi_closed) { create(:groupe_instructeur, procedure:, closed: true) }
before { procedure.defaut_groupe_instructeur.destroy! }
it "closed is valid when there is one other active groupe" do
expect(gi_active).to be_valid
expect(gi_closed).to be_valid
end
it "closed is invalid when there is no active groupe" do
gi_active.closed = true
expect(gi_active).not_to be_valid
end
end
end
private
def assign(procedure_to_assign, instructeur_assigne: instructeur)