DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix: do not retry rnf bad request

Browse source
This commit is contained in:
simon lehericey 2024-03-29 12:20:04 +01:00
parent dd6c558541
commit 8405c83c12
No known key found for this signature in database
GPG key ID: CDE670D827C7B3C5
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/services/rnf_service.rb
View file

@ -8,6 +8,10 @@ class RNFService
Success(body) Success(body)
in Failure(code:, reason:) if code.in?(401..403) in Failure(code:, reason:) if code.in?(401..403)
Failure(API::Client::Error[:unauthorized, code, false, reason]) Failure(API::Client::Error[:unauthorized, code, false, reason])
# 400 errors are due to invalid rfn code
# it cannot be fixed so we do not retry
in Failure(code: 400, reason:)
Failure(API::Client::Error[:bad_request, code, false, reason])
else else
result result
end end

9
spec/models/champs/rnf_champ_spec.rb
View file

@ -72,6 +72,15 @@ describe Champs::RNFChamp, type: :model do
expect(subject.failure.reason).to be_a(API::Client::HTTPError) expect(subject.failure.reason).to be_a(API::Client::HTTPError)
} }
end end
context 'failure (http 400)' do
let(:status) { 400 }
let(:response_type) { 'invalid' }
it {
expect(subject.failure.retryable).to be_falsey
expect(subject.failure.reason).to be_a(API::Client::HTTPError)
}
end
end end
describe 'for_export' do describe 'for_export' do