DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

tech(refactor): inline PiecesJustificativesService.serialize_champs_as_pjs(object) within DossierSerializer

Browse source
This commit is contained in:
Martin 2024-02-07 17:31:54 +01:00
parent 56ed901703
commit 83690529ca
2 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/serializers/dossier_serializer.rb
View file

@ -55,7 +55,14 @@ class DossierSerializer < ActiveModel::Serializer
end end
def pieces_justificatives def pieces_justificatives
PiecesJustificativesService.serialize_champs_as_pjs(object) object.champs_public.filter { |champ| champ.type_de_champ.old_pj }.map do |champ|
{
created_at: champ.created_at&.in_time_zone('UTC'),
type_de_piece_justificative_id: champ.type_de_champ.old_pj[:stable_id],
content_url: champ.for_api,
user: champ.dossier.user
}
end.flatten
end end
def attestation def attestation

11
app/services/pieces_justificatives_service.rb
View file

@ -48,17 +48,6 @@ class PiecesJustificativesService
end end
end end
def self.serialize_champs_as_pjs(dossier)
dossier.champs_public.filter { |champ| champ.type_de_champ.old_pj }.map do |champ|
{
created_at: champ.created_at&.in_time_zone('UTC'),
type_de_piece_justificative_id: champ.type_de_champ.old_pj[:stable_id],
content_url: champ.for_api,
user: champ.dossier.user
}
end.flatten
end
def self.generate_dossier_export(dossiers, include_infos_administration: false, include_avis_for_expert: false) def self.generate_dossier_export(dossiers, include_infos_administration: false, include_avis_for_expert: false)
return [] if dossiers.empty? return [] if dossiers.empty?