DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

javascript: ignore most common upload errors also in standard uploads

Browse source 
In #5149, we ignored most common upload errors, but only for
auto-uploads.

This PR ignores those errors also for standard uploads.
This commit is contained in:
Pierre de La Morinerie 2020-05-14 15:52:43 +02:00
parent 2762bd8a80
commit 833d7a3b59
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/javascript/shared/activestorage/ujs.js
View file

@ -1,7 +1,8 @@
import ProgressBar from './progress-bar'; import ProgressBar from './progress-bar';
import { import {
errorFromDirectUploadMessage, errorFromDirectUploadMessage,
FAILURE_CONNECTIVITY ERROR_CODE_READ,
FAILURE_CLIENT
} from './file-upload-error'; } from './file-upload-error';
import { fire } from '@utils'; import { fire } from '@utils';
@ -58,8 +59,10 @@ addUploadEventListener(ERROR_EVENT, (event) => {
ProgressBar.error(id, errorMsg); ProgressBar.error(id, errorMsg);
// Report unexpected client errors to Sentry.
// (But ignore usual client errors, or errors we can monitor better on the server side.)
let error = errorFromDirectUploadMessage(errorMsg); let error = errorFromDirectUploadMessage(errorMsg);
if (error.failureReason != FAILURE_CONNECTIVITY) { if (error.failureReason == FAILURE_CLIENT && error.code != ERROR_CODE_READ) {
fire(document, 'sentry:capture-exception', error); fire(document, 'sentry:capture-exception', error);
} }
}); });