DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Add a method name to better separate responsabilities

Browse source 
Also rename a method to better reflect what it does
This commit is contained in:
gregoirenovel 2018-04-06 09:15:35 +02:00
parent ca3e73440b
commit 82d6f0b8a8
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/manager/demandes_controller.rb
View file

@ -56,7 +56,7 @@ module Manager
end end
def demandes def demandes
@demandes ||= PipedriveService.fetch_people_demandes @demandes ||= PipedriveService.get_demandes
end end
end end
end end

10
app/services/pipedrive_service.rb
View file

@ -30,7 +30,11 @@ class PipedriveService
update_person_owner(person_id, owner_id) update_person_owner(person_id, owner_id)
end end
def fetch_people_demandes def get_demandes
get_demandes_from_persons_owned_by_robot
end
def get_demandes_from_persons_owned_by_robot
params = { params = {
start: 0, start: 0,
limit: 500, limit: 500,
@ -39,9 +43,9 @@ class PipedriveService
} }
response = RestClient.get(PIPEDRIVE_PEOPLE_URL, { params: params }) response = RestClient.get(PIPEDRIVE_PEOPLE_URL, { params: params })
json = JSON.parse(response.body) json_data = JSON.parse(response.body)['data']
json['data'].map do |datum| json_data.map do |datum|
{ {
person_id: datum['id'], person_id: datum['id'],
nom: datum['name'], nom: datum['name'],