Enable some flags for all (#4158)

Activation des blocs répératables et de l'export tableur v2 pour toutes les démarches

app/controllers/application_controller.rb

@@ -183,7 +183,7 @@ class ApplicationController < ActionController::Base
   def redirect_if_untrusted
     if instructeur_signed_in? &&
         sensitive_path &&
-        Flipflop.enable_email_login_token? &&
+        !Flipflop.bypass_email_login_token? &&
         !IPService.ip_trusted?(request.headers['X-Forwarded-For']) &&
         !trusted_device?
 

app/helpers/procedure_helper.rb

@@ -64,8 +64,7 @@ module ProcedureHelper
   private
 
   TOGGLES = {
-    TypeDeChamp.type_champs.fetch(:integer_number)  => :champ_integer_number?,
+    TypeDeChamp.type_champs.fetch(:integer_number) => :champ_integer_number?
-    TypeDeChamp.type_champs.fetch(:repetition)      => :champ_repetition?
   }
 
   def types_de_champ_types

app/views/instructeurs/procedures/_download_dossiers.html.haml

@@ -4,11 +4,8 @@
       Télécharger tous les dossiers
     - old_format_limit_date = Date.parse("Oct 31 2019")
     - export_v1_enabled = old_format_limit_date > Time.zone.today
-    - export_v2_enabled = Flipflop.procedure_export_v2_enabled? || !export_v1_enabled
+    .dropdown-content.fade-in-down{ style: !export_v1_enabled ? 'width: 330px' : '' }
-    - old_format_message = export_v1_enabled && export_v2_enabled ? "(ancien format, jusqu’au #{old_format_limit_date.strftime('%d/%m/%Y')})" : ''
-    .dropdown-content.fade-in-down{ style: export_v1_enabled && export_v2_enabled ? 'width: 330px' : '' }
       %ul.dropdown-items
-        - if export_v2_enabled
         %li
           = link_to "Au format .xlsx", procedure_dossiers_download_path(procedure, format: :xlsx, version: 'v2'), target: "_blank", rel: "noopener"
         %li
@@ -16,6 +13,7 @@
         %li
           = link_to "Au format .csv", procedure_dossiers_download_path(procedure, format: :csv, version: 'v2'), target: "_blank", rel: "noopener"
         - if export_v1_enabled
+          - old_format_message = "(ancien format, jusqu’au #{old_format_limit_date.strftime('%d/%m/%Y')})"
           %li
             = link_to "Au format .xlsx #{old_format_message}", procedure_dossiers_download_path(procedure, format: :xlsx, version: 'v1'), target: "_blank", rel: "noopener"
           %li

config/features.rb

@@ -9,17 +9,14 @@ Flipflop.configure do
   group :champs do
     feature :champ_integer_number,
       title: "Champ nombre entier"
-    feature :champ_repetition,
-      title: "Bloc répétable"
   end
 
   feature :web_hook
-  feature :enable_email_login_token
 
-  feature :procedure_export_v2_enabled
   feature :operation_log_serialize_subject
-  feature :download_as_zip_enabled,
+  feature :download_as_zip_enabled
-    default: false
+  feature :bypass_email_login_token,
+    default: Rails.env.test?
 
   group :development do
     feature :mini_profiler_enabled,

lib/tasks/2018_11_08_activate_trusted_device_for_a-f.rake

@@ -1,8 +0,0 @@
-namespace :'activate_trusted_device_for_a-f' do
-  task run: :environment do
-    letters_a_to_f = ('a'..'f').to_a
-    Gestionnaire
-      .where("substr(email, 1, 1) IN (?)", letters_a_to_f)
-      .update_all(features: { "enable_email_login_token" => true })
-  end
-end

spec/controllers/application_controller_spec.rb

@@ -166,14 +166,13 @@ describe ApplicationController, type: :controller do
     context 'when the path is sensitive' do
       let(:sensitive_path) { true }
 
+      before do
+        Flipflop::FeatureSet.current.test!.switch!(:bypass_email_login_token, false)
+      end
+
       context 'when the instructeur is signed_in' do
         let(:instructeur_signed_in) { true }
 
-        context 'when the feature is activated' do
-          before do
-            Flipflop::FeatureSet.current.test!.switch!(:enable_email_login_token, true)
-          end
-
         context 'when the ip is not trusted' do
           let(:ip_trusted) { false }
 
@@ -184,16 +183,6 @@ describe ApplicationController, type: :controller do
 
             it { expect(@controller).not_to have_received(:redirect_to) }
           end
-          end
-        end
-
-        context 'when the feature is activated' do
-          before do
-            Flipflop::FeatureSet.current.test!.switch!(:enable_email_login_token, true)
-          end
-
-          context 'when the ip is untrusted' do
-            let(:ip_trusted) { false }
 
           context 'when the device is not trusted' do
             let(:trusted_device) { false }
@@ -221,4 +210,3 @@ describe ApplicationController, type: :controller do
     end
   end
 end
-end

spec/controllers/users/sessions_controller_spec.rb

@@ -17,7 +17,6 @@ describe Users::SessionsController, type: :controller do
       let(:send_password) { password }
 
       before do
-        Flipflop::FeatureSet.current.test!.switch!(:enable_email_login_token, true)
         allow(controller).to receive(:trusted_device?).and_return(trusted_device)
         allow(InstructeurMailer).to receive(:send_login_token).and_return(double(deliver_later: true))
       end
@@ -28,6 +27,9 @@ describe Users::SessionsController, type: :controller do
       end
 
       context 'when the device is not trusted' do
+        before do
+          Flipflop::FeatureSet.current.test!.switch!(:bypass_email_login_token, false)
+        end
         let(:trusted_device) { false }
 
         it 'redirects to the send_linked_path' do

spec/features/instructeurs/instructeur_spec.rb

@@ -9,10 +9,6 @@ feature 'The instructeur part' do
   let!(:procedure) { create(:procedure, :published, instructeurs: [instructeur]) }
   let!(:dossier) { create(:dossier, state: Dossier.states.fetch(:en_construction), procedure: procedure) }
 
-  before do
-    Flipflop::FeatureSet.current.test!.switch!(:enable_email_login_token, true)
-  end
-
   context 'the instructeur is also a user' do
     scenario 'a instructeur can fill a dossier' do
       visit commencer_path(path: procedure.path)

spec/features/new_administrateur/types_de_champ_spec.rb

@@ -5,7 +5,6 @@ feature 'As an administrateur I can edit types de champ', js: true do
   let(:procedure) { create(:procedure) }
 
   before do
-    Flipflop::FeatureSet.current.test!.switch!(:champ_repetition, true)
     login_as administrateur, scope: :administrateur
     visit champs_procedure_path(procedure)
   end

spec/models/instructeur_spec.rb

@@ -12,10 +12,6 @@ describe Instructeur, type: :model do
     assign(procedure_2)
   end
 
-  describe 'default features' do
-    it { expect(instructeur.features).to eq({ "enable_email_login_token" => true }) }
-  end
-
   describe '#visible_procedures' do
     let(:procedure_not_assigned)           { create :procedure, administrateur: admin }
     let(:procedure_with_default_path)      { create :procedure, administrateur: admin }

spec/support/feature_helpers.rb

@@ -21,6 +21,10 @@ module FeatureHelpers
     fill_in :user_email, with: email
     fill_in :user_password, with: password
 
+    if sign_in_by_link
+      Flipflop::FeatureSet.current.test!.switch!(:bypass_email_login_token, false)
+    end
+
     perform_enqueued_jobs do
       click_on 'Se connecter'
     end