DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feat(conditional): remove conditional feature flag

Browse source
This commit is contained in:
Paul Chavard 2022-11-04 13:37:37 +00:00
parent 472d075634
commit 7de52d582a
3 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/components/types_de_champ_editor/champ_component.rb
View file

@ -120,10 +120,6 @@ class TypesDeChampEditor::ChampComponent < ApplicationComponent
end end
def conditional_enabled? def conditional_enabled?
if type_de_champ.private? || coordinate.child? !type_de_champ.private? && !coordinate.child?
false
else
procedure.feature_enabled?(:procedure_conditional)
end
end end
end end

3
config/initializers/flipper.rb
View file

@ -25,8 +25,7 @@ features = [
:expert_not_allowed_to_invite, :expert_not_allowed_to_invite,
:hide_instructeur_email, :hide_instructeur_email,
:procedure_revisions, :procedure_revisions,
:procedure_routage_api, :procedure_routage_api
:procedure_conditional
] ]
def database_exists? def database_exists?

2
spec/system/administrateurs/condition_spec.rb
View file

@ -17,8 +17,6 @@ describe 'As an administrateur I can edit types de champ condition', js: true do
before do before do
login_as administrateur.user, scope: :user login_as administrateur.user, scope: :user
# TODO: remove along with feature flipping
Flipper.enable(:procedure_conditional, procedure)
visit champs_admin_procedure_path(procedure) visit champs_admin_procedure_path(procedure)
end end