DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2986 from betagouv/restrict-dossier-time-estimation

Browse source 
Restreint l'estimation de la durée de traitement à un mois
This commit is contained in:
Pierre de La Morinerie 2018-11-13 17:24:22 +01:00 committed by GitHub
commit 7c6437b01a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/models/procedure.rb
View file

@ -426,6 +426,7 @@ class Procedure < ApplicationRecord
def percentile_time(start_attribute, end_attribute, p)
times = dossiers
.state_termine
.where(end_attribute => 1.month.ago..DateTime.current)
.pluck(start_attribute, end_attribute)
.map { |(start_date, end_date)| end_date - start_date }

21
spec/models/procedure_spec.rb
View file

@ -708,12 +708,14 @@ describe Procedure do
describe '#usual_instruction_time' do
let(:procedure) { create(:procedure) }
def create_dossier(instruction_date:, processed_date:)
dossier = create(:dossier, :accepte, procedure: procedure)
dossier.update!(en_instruction_at: instruction_date, processed_at: processed_date)
end
before do
processed_delays.each do |delay|
dossier = create :dossier, :accepte, procedure: procedure
instruction_date = 1.month.ago
processed_date = instruction_date + delay
dossier.update!(en_instruction_at: instruction_date, processed_at: processed_date)
create_dossier(instruction_date: 1.week.ago - delay, processed_date: 1.week.ago)
end
end
@ -725,9 +727,18 @@ describe Procedure do
end
end
context 'when there are very old dossiers' do
let(:processed_delays) { [2.days, 2.days] }
let!(:old_dossier) { create_dossier(instruction_date: 3.months.ago, processed_date: 2.months.ago) }
it 'ignores dossiers older than 1 month' do
expect(procedure.usual_instruction_time).to be_within(10.seconds).of(2.days)
end
end
context 'when there is only one processed dossier' do
let(:processed_delays) { [1.day] }
it { expect(procedure.usual_instruction_time).to eq(1.day) }
it { expect(procedure.usual_instruction_time).to be_within(10.seconds).of(1.day) }
end
context 'where there is no processed dossier' do