Don’t use unless

spec/factories/avis.rb

@@ -3,19 +3,19 @@ FactoryGirl.define do
     introduction 'Bonjour, merci de me donner votre avis sur ce dossier'
 
     before(:create) do |avis, _evaluator|
-      unless avis.gestionnaire
+      if !avis.gestionnaire
         avis.gestionnaire = create :gestionnaire
       end
     end
 
     before(:create) do |avis, _evaluator|
-      unless avis.dossier
+      if !avis.dossier
         avis.dossier = create :dossier
       end
     end
 
     before(:create) do |avis, _evaluator|
-      unless avis.claimant
+      if !avis.claimant
         avis.claimant = create :gestionnaire
       end
     end

spec/factories/commentaire.rb

@@ -3,7 +3,7 @@ FactoryGirl.define do
     body 'plop'
 
     before(:create) do |commentaire, _evaluator|
-      unless commentaire.dossier
+      if !commentaire.dossier
         commentaire.dossier = create :dossier
       end
     end

spec/factories/dossier.rb

@@ -4,7 +4,7 @@ FactoryGirl.define do
     association :user, factory: [:user]
 
     before(:create) do |dossier, _evaluator|
-      unless dossier.procedure
+      if !dossier.procedure
         procedure = create(:procedure, :published, :with_two_type_de_piece_justificative, :with_type_de_champ, :with_type_de_champ_private)
         dossier.procedure = procedure
       end

spec/factories/invite.rb

@@ -7,7 +7,7 @@ FactoryGirl.define do
         invite.dossier = create(:dossier)
       end
 
-      unless invite.user.nil?
+      if invite.user.present?
         invite.email = invite.user.email
       end
     end

spec/factories/invite_user.rb

@@ -7,7 +7,7 @@ FactoryGirl.define do
         invite.dossier = create(:dossier)
       end
 
-      unless invite.user.nil?
+      if invite.user.present?
         invite.email = invite.user.email
       end
     end

spec/factories/notification.rb

@@ -4,7 +4,7 @@ FactoryGirl.define do
     liste []
 
     before(:create) do |notification, _evaluator|
-      unless notification.dossier
+      if !notification.dossier
         notification.dossier = create :dossier
       end
     end