Merge pull request #5058 from betagouv/fix-search-sql

fix to_tsquery disallowed chars

app/services/dossier_search_service.rb

@@ -62,8 +62,8 @@ class DossierSearchService
 
   def self.to_tsquery(search_terms)
     (search_terms || "")
-      .strip
       .gsub(/['?\\:&|!<>\(\)]/, "") # drop disallowed characters
+      .strip
       .split(/\s+/)           # split words
       .map { |x| "#{x}:*" }   # enable prefix matching
       .join(" & ")

spec/services/dossier_search_service_spec.rb

@@ -198,5 +198,11 @@ describe DossierSearchService do
 
       it { expect(subject.size).to eq(1) }
     end
+
+    describe 'search with a single forbidden character should not crash postgres' do
+      let(:terms) { '? OCTO' }
+
+      it { expect(subject.size).to eq(3) }
+    end
   end
 end