DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Do not hide not notified dossier

Browse source
This commit is contained in:
Mathieu Magnin 2024-12-06 16:33:33 +01:00
parent 53ce0e05f6
commit 760963a52d
No known key found for this signature in database
GPG key ID: 8DCAFC82D7BA654E
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/jobs/cron/purge_old_brouillon_dossiers_job.rb
View file

@ -7,7 +7,7 @@ class Cron::PurgeOldBrouillonDossiersJob < Cron::CronJob
Dossier Dossier
.visible_by_user .visible_by_user
.state_brouillon .state_brouillon
.where(updated_at: ..(3.months + 2.weeks).ago) .where(updated_at: ..(3.months + 2.weeks).ago, notified_soon_deleted_sent_at: ..2.weeks.ago)
.find_each do |dossier| .find_each do |dossier|
dossier.hide_and_keep_track!(:automatic, :not_modified_for_a_long_time) dossier.hide_and_keep_track!(:automatic, :not_modified_for_a_long_time)
DossierMailer.notify_old_brouillon_after_deletion(dossier).deliver_later DossierMailer.notify_old_brouillon_after_deletion(dossier).deliver_later

15
spec/jobs/cron/purge_old_brouillon_dossiers_job_spec.rb
View file

@ -3,12 +3,13 @@
RSpec.describe Cron::PurgeOldBrouillonDossiersJob, type: :job do RSpec.describe Cron::PurgeOldBrouillonDossiersJob, type: :job do
let(:procedure) { create(:procedure) } let(:procedure) { create(:procedure) }
let!(:recent_brouillon) { travel_to(3.months.ago) { create(:dossier, :brouillon, procedure: procedure) } } let!(:recent_brouillon) { travel_to(3.months.ago) { create(:dossier, :brouillon, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
let!(:old_brouillon) { travel_to(5.months.ago) { create(:dossier, :brouillon, procedure: procedure) } } let!(:old_brouillon) { travel_to(5.months.ago) { create(:dossier, :brouillon, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
let!(:very_old_brouillon) { travel_to(6.months.ago) { create(:dossier, :brouillon, procedure: procedure) } } let!(:very_old_brouillon) { travel_to(6.months.ago) { create(:dossier, :brouillon, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
let!(:old_en_construction) { travel_to(5.months.ago) { create(:dossier, :en_construction, procedure: procedure) } } let!(:very_old_brouillon_but_not_notified) { travel_to(6.months.ago) { create(:dossier, :brouillon, procedure: procedure, notified_soon_deleted_sent_at: nil) } }
let!(:not_visible_dossier) { travel_to(6.months.ago) { create(:dossier, :brouillon, :hidden_by_user, procedure: procedure) } } let!(:old_en_construction) { travel_to(5.months.ago) { create(:dossier, :en_construction, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
let!(:not_visible_dossier2) { travel_to(6.months.ago) { create(:dossier, :brouillon, :hidden_by_expired, procedure: procedure) } } let!(:not_visible_dossier) { travel_to(6.months.ago) { create(:dossier, :brouillon, :hidden_by_user, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
let!(:not_visible_dossier2) { travel_to(6.months.ago) { create(:dossier, :brouillon, :hidden_by_expired, procedure: procedure, notified_soon_deleted_sent_at: 3.weeks.ago) } }
subject(:perform_job) { described_class.perform_now } subject(:perform_job) { described_class.perform_now }
@ -19,8 +20,6 @@ RSpec.describe Cron::PurgeOldBrouillonDossiersJob, type: :job do
it 'hides only old brouillon dossiers' do it 'hides only old brouillon dossiers' do
expect { perform_job }.to change { Dossier.visible_by_user.count }.by(-2) expect { perform_job }.to change { Dossier.visible_by_user.count }.by(-2)
expect(Dossier.visible_by_user.pluck(:id)).to match_array([recent_brouillon.id, old_en_construction.id])
end end
it 'sends notification emails for each hidden dossier' do it 'sends notification emails for each hidden dossier' do