Merge pull request #4472 from betagouv/fix-helpscout-webhook

Webhook : correction d'une exception lorsque l'adresse email du client est inconnue

app/controllers/webhook_controller.rb

@@ -4,14 +4,16 @@ class WebhookController < ActionController::Base
   def helpscout
     email = params[:customer][:email].downcase
     user = User.find_by(email: email)
+
+    if user.nil?
+      head :not_found
+
+    else
       instructeur = user.instructeur
       administrateur = user.administrateur
-    html = []
 
-    if user
       url = manager_user_url(user)
-      html << link_to_manager(user, url)
-    end
+      html = [link_to_manager(user, url)]
 
       if instructeur
         url = manager_instructeur_url(instructeur)
@@ -23,9 +25,6 @@ class WebhookController < ActionController::Base
         html << link_to_manager(administrateur, url)
       end
 
-    if html.empty?
-      head :not_found
-    else
       render json: { html: html.join('<br>') }
     end
   end

spec/controllers/webhook_controller_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe WebhookController, type: :controller do
+  describe '#helpscout' do
+    before { allow(controller).to receive(:verify_signature!).and_return(true) }
+
+    subject(:response) { get :helpscout, params: { customer: { email: customer_email } } }
+
+    let(:payload) { JSON.parse(subject.body) }
+
+    context 'when there is no matching user' do
+      let(:customer_email) { 'not-a-user@exemple.fr' }
+
+      it 'returns an empty response' do
+        expect(subject.status).to eq(404)
+        expect(subject.body).to be_empty
+      end
+    end
+
+    context 'when there is a matching user' do
+      let(:user) { create(:user) }
+      let(:customer_email) { user.email }
+
+      it 'returns a 200 response' do
+        expect(subject.status).to eq(200)
+        expect(subject.body).to be_present
+      end
+
+      it 'returns a link to the User profile in the Manager' do
+        expect(payload).to have_key('html')
+        expect(payload['html']).to have_selector("a[href='#{manager_user_url(user)}']")
+      end
+
+      context 'when there are an associated Instructeur and Administrateur' do
+        let!(:instructeur) { create(:instructeur,    user: user) }
+        let!(:admin)       { create(:administrateur, user: user) }
+
+        it 'returns a link to the Instructeur profile in the Manager' do
+          expect(payload).to have_key('html')
+          expect(payload['html']).to have_selector("a[href='#{manager_instructeur_url(instructeur)}']")
+        end
+
+        it 'returns a link to the Administrateur profile in the Manager' do
+          expect(payload).to have_key('html')
+          expect(payload['html']).to have_selector("a[href='#{manager_administrateur_url(admin)}']")
+        end
+      end
+    end
+  end
+end