DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Revert "app: hide IE11 deprecation banner during the strike"

Browse source 
This reverts commit c2882b6cc3.
This commit is contained in:
Pierre de La Morinerie 2020-01-28 11:28:12 +01:00
parent d73dbc5056
commit 745b00366f
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
config/initializers/browser.rb
View file

@ -2,7 +2,6 @@
Browser.modern_rules.clear Browser.modern_rules.clear
Browser.modern_rules << -> b { b.chrome? && b.version.to_i >= 50 && !b.platform.ios? } Browser.modern_rules << -> b { b.chrome? && b.version.to_i >= 50 && !b.platform.ios? }
Browser.modern_rules << -> b { b.edge? && b.version.to_i >= 14 && !b.compatibility_view? } Browser.modern_rules << -> b { b.edge? && b.version.to_i >= 14 && !b.compatibility_view? }
Browser.modern_rules << -> b { b.ie? && b.version.to_i >= 11 && !b.compatibility_view? }
Browser.modern_rules << -> b { b.firefox? && b.version.to_i >= 50 && !b.platform.ios? } Browser.modern_rules << -> b { b.firefox? && b.version.to_i >= 50 && !b.platform.ios? }
Browser.modern_rules << -> b { b.opera? && b.version.to_i >= 40 } Browser.modern_rules << -> b { b.opera? && b.version.to_i >= 40 }
Browser.modern_rules << -> b { b.safari? && b.version.to_i >= 8 } Browser.modern_rules << -> b { b.safari? && b.version.to_i >= 8 }

12
spec/features/outdated_browser_spec.rb
View file

@ -3,29 +3,29 @@ require 'spec_helper'
feature 'Outdated browsers support:' do feature 'Outdated browsers support:' do
context 'when the user browser is outdated' do context 'when the user browser is outdated' do
before(:each) do before(:each) do
ie_10_user_agent = 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0)' ie_11_user_agent = 'Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko'
Capybara.page.driver.header('user-agent', ie_10_user_agent) Capybara.page.driver.header('user-agent', ie_11_user_agent)
end end
scenario 'a banner is displayed' do scenario 'a banner is displayed' do
visit new_user_session_path visit new_user_session_path
expect(page).to have_content('Internet Explorer 10 est trop ancien') expect(page).to have_content('Internet Explorer 11 est trop ancien')
end end
scenario 'the banner can be dismissed' do scenario 'the banner can be dismissed' do
visit new_user_session_path visit new_user_session_path
expect(page).to have_content('Internet Explorer 10 est trop ancien') expect(page).to have_content('Internet Explorer 11 est trop ancien')
# The banner is hidden immediately # The banner is hidden immediately
within '#outdated-browser-banner' do within '#outdated-browser-banner' do
click_on 'Ignorer' click_on 'Ignorer'
end end
expect(page).not_to have_content('Internet Explorer 10 est trop ancien') expect(page).not_to have_content('Internet Explorer 11 est trop ancien')
expect(page).to have_current_path(new_user_session_path) expect(page).to have_current_path(new_user_session_path)
# The banner is hidden after a refresh # The banner is hidden after a refresh
page.refresh page.refresh
expect(page).not_to have_content('Internet Explorer 10 est trop ancien') expect(page).not_to have_content('Internet Explorer 11 est trop ancien')
end end
end end
end end