Merge pull request #2915 from betagouv/dev

2018-10-26-02

app/models/procedure_presentation.rb

@@ -111,7 +111,7 @@ class ProcedurePresentation < ApplicationRecord
       column = sanitized_column(filter)
       case table
       when 'self'
-        date = Time.zone.parse(filter['value'])
+        date = Time.zone.parse(filter['value']) rescue nil
         if date.present?
           dossiers.where("#{column} BETWEEN ? AND ?", date, date + 1.day)
         else

spec/models/procedure_presentation_spec.rb

@@ -406,8 +406,16 @@ describe ProcedurePresentation do
       end
 
       context 'for a malformed date' do
-        let(:filter) { [{ 'table' => 'self', 'column' => 'updated_at', 'value' => 'malformed date' }] }
-        it { is_expected.to match([]) }
+        context 'when its a string' do
+          let(:filter) { [{ 'table' => 'self', 'column' => 'updated_at', 'value' => 'malformed date' }] }
+          it { is_expected.to match([]) }
+        end
+
+        context 'when its a number' do
+          let(:filter) { [{ 'table' => 'self', 'column' => 'updated_at', 'value' => '177500' }] }
+
+          it { is_expected.to match([]) }
+        end
       end
     end