[Fix #164] Make the organisme field mandatory

This commit is contained in:
gregoirenovel 2017-11-23 11:37:41 +01:00
parent d88b82eebf
commit 731e1b6787
6 changed files with 16 additions and 1 deletions

View file

@ -40,6 +40,7 @@ class Procedure < ActiveRecord::Base
validates :libelle, presence: true, allow_blank: false, allow_nil: false validates :libelle, presence: true, allow_blank: false, allow_nil: false
validates :description, presence: true, allow_blank: false, allow_nil: false validates :description, presence: true, allow_blank: false, allow_nil: false
validates :organisation, presence: true, allow_blank: false, allow_nil: false
def hide! def hide!
now = DateTime.now now = DateTime.now

View file

@ -2,7 +2,7 @@
.alert.alert-info .alert.alert-info
Cette procédure est publiée, certains éléments de la description ne sont plus modifiables Cette procédure est publiée, certains éléments de la description ne sont plus modifiables
- { libelle: 'Libellé*', description: 'Description*', organisation: 'Organisme', direction: 'Direction', lien_site_web: 'Lien site internet', lien_notice: 'Lien notice' }.each do |key, value| - { libelle: 'Libellé*', description: 'Description*', organisation: 'Organisme*', direction: 'Direction', lien_site_web: 'Lien site internet', lien_notice: 'Lien notice' }.each do |key, value|
.form-group .form-group
%h4 %h4
= value = value

View file

@ -1,5 +1,8 @@
fr: fr:
activerecord: activerecord:
attributes:
procedure:
organisation: Organisme
errors: errors:
models: models:
procedure: procedure:
@ -10,3 +13,5 @@ fr:
blank: Attribut manquant blank: Attribut manquant
lien_demarche: lien_demarche:
blank: Attribut manquant blank: Attribut manquant
organisation:
blank: Attribut manquant

View file

@ -13,6 +13,7 @@ feature 'As an administrateur I wanna clone a procedure', js: true do
page.find_by_id('new-procedure').click page.find_by_id('new-procedure').click
fill_in 'procedure_libelle', with: 'libelle de la procedure' fill_in 'procedure_libelle', with: 'libelle de la procedure'
page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')") page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')")
fill_in 'procedure_organisation', with: 'organisme de la procedure'
page.find_by_id('save-procedure').click page.find_by_id('save-procedure').click
end end

View file

@ -37,6 +37,7 @@ feature 'As an administrateur I wanna create a new procedure', js: true do
page.find_by_id('flash_message').visible? page.find_by_id('flash_message').visible?
fill_in 'procedure_libelle', with: 'libelle de la procedure' fill_in 'procedure_libelle', with: 'libelle de la procedure'
page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')") page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')")
fill_in 'procedure_organisation', with: 'organisme de la procedure'
page.find_by_id('save-procedure').click page.find_by_id('save-procedure').click
expect(page).to have_current_path(admin_procedure_types_de_champ_path(Procedure.first.id.to_s)) expect(page).to have_current_path(admin_procedure_types_de_champ_path(Procedure.first.id.to_s))
end end
@ -47,6 +48,7 @@ feature 'As an administrateur I wanna create a new procedure', js: true do
page.find_by_id('new-procedure').click page.find_by_id('new-procedure').click
fill_in 'procedure_libelle', with: 'libelle de la procedure' fill_in 'procedure_libelle', with: 'libelle de la procedure'
page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')") page.execute_script("$('#procedure_description').data('wysihtml5').editor.setValue('description de la procedure')")
fill_in 'procedure_organisation', with: 'organisme de la procedure'
page.find_by_id('save-procedure').click page.find_by_id('save-procedure').click
end end

View file

@ -57,6 +57,12 @@ describe Procedure do
it { is_expected.to allow_value('').for(:lien_demarche) } it { is_expected.to allow_value('').for(:lien_demarche) }
it { is_expected.to allow_value('http://localhost').for(:lien_demarche) } it { is_expected.to allow_value('http://localhost').for(:lien_demarche) }
end end
context 'organisation' do
it { is_expected.not_to allow_value(nil).for(:organisation) }
it { is_expected.not_to allow_value('').for(:organisation) }
it { is_expected.to allow_value('URRSAF').for(:organisation) }
end
end end
describe '#types_de_champ_ordered' do describe '#types_de_champ_ordered' do